Skip to content

Commit fbe69b2

Browse files
committed
fix: add extends support for v1.12+
1 parent ed7350d commit fbe69b2

File tree

3 files changed

+40
-18
lines changed

3 files changed

+40
-18
lines changed

lib/extend.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,19 @@ try {
1515
Page = require('puppeteer/lib/Page.js') // tslint:disable-line
1616
if (Page.Page) Page = Page.Page
1717

18-
ElementHandle = requireOrUndefined('puppeteer/lib/ElementHandle.js') // tslint:disable-line
18+
ElementHandle = requireOrUndefined('puppeteer/lib/ElementHandle.js') // tslint:disable-line variable-name
1919
if (!ElementHandle) {
20-
ElementHandle = require('puppeteer/lib/ExecutionContext.js').ElementHandle // tslint:disable-line
20+
const ExecutionContext = requireOrUndefined('puppeteer/lib/ExecutionContext.js') // tslint:disable-line variable-name
21+
if (ExecutionContext && ExecutionContext.ElementHandle) {
22+
ElementHandle = ExecutionContext.ElementHandle
23+
}
24+
}
25+
26+
if (!ElementHandle) {
27+
const JSHandle = require('puppeteer/lib/JSHandle.js') // tslint:disable-line
28+
if (JSHandle && JSHandle.ElementHandle) {
29+
ElementHandle = JSHandle.ElementHandle
30+
}
2131
}
2232

2333
Page.prototype.getDocument = getDocument

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"@types/puppeteer": "^1.10.0",
5252
"generate-export-aliases": "^1.1.0",
5353
"jest": "^23.1.0",
54-
"puppeteer": "^1.10.0",
54+
"puppeteer": "^1.16.0",
5555
"rollup": "^0.61.1",
5656
"rollup-plugin-commonjs": "^9.1.3",
5757
"rollup-plugin-node-resolve": "^3.3.0",

yarn.lock

Lines changed: 27 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,6 +1189,13 @@ debug@^3.1.0:
11891189
dependencies:
11901190
ms "2.0.0"
11911191

1192+
debug@^4.1.0:
1193+
version "4.1.1"
1194+
resolved "https://registry.yarnpkg.com/debug/-/debug-4.1.1.tgz#3b72260255109c6b589cee050f1d516139664791"
1195+
integrity sha512-pYAIzeRo8J6KPEaJ0VWOh5Pzkbw/RetuzehGM7QRRX5he4fPHx2rdKMB256ehJCkX+XRQm16eZLqLNS8RSZXZw==
1196+
dependencies:
1197+
ms "^2.1.1"
1198+
11921199
decamelize@^1.0.0, decamelize@^1.1.1:
11931200
version "1.2.0"
11941201
resolved "https://registry.yarnpkg.com/decamelize/-/decamelize-1.2.0.tgz#f6534d15148269b20352e7bee26f501f9a191290"
@@ -3734,6 +3741,11 @@ [email protected]:
37343741
resolved "https://registry.yarnpkg.com/ms/-/ms-2.0.0.tgz#5608aeadfc00be6c2901df5f9861788de0d597c8"
37353742
integrity sha1-VgiurfwAvmwpAd9fmGF4jeDVl8g=
37363743

3744+
ms@^2.1.1:
3745+
version "2.1.1"
3746+
resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.1.tgz#30a5864eb3ebb0a66f2ebe6d727af06a09d86e0a"
3747+
integrity sha512-tgp+dl5cGk28utYktBsrFqA7HKgrhgPsg6Z/EfhWI4gl1Hwq8B/GmY/0oXZ6nF8hDVesS/FpnYaD/kOWhYQvyg==
3748+
37373749
37383750
version "0.0.5"
37393751
resolved "https://registry.yarnpkg.com/mute-stream/-/mute-stream-0.0.5.tgz#8fbfabb0a98a253d3184331f9e8deb7372fac6c0"
@@ -4294,10 +4306,10 @@ progress@^1.1.8:
42944306
resolved "https://registry.yarnpkg.com/progress/-/progress-1.1.8.tgz#e260c78f6161cdd9b0e56cc3e0a85de17c7a57be"
42954307
integrity sha1-4mDHj2Fhzdmw5WzD4Khd4Xx6V74=
42964308

4297-
progress@^2.0.0:
4298-
version "2.0.0"
4299-
resolved "https://registry.yarnpkg.com/progress/-/progress-2.0.0.tgz#8a1be366bf8fc23db2bd23f10c6fe920b4389d1f"
4300-
integrity sha1-ihvjZr+Pwj2yvSPxDG/pILQ4nR8=
4309+
progress@^2.0.1:
4310+
version "2.0.3"
4311+
resolved "https://registry.yarnpkg.com/progress/-/progress-2.0.3.tgz#7e8cf8d8f5b8f239c1bc68beb4eb78567d572ef8"
4312+
integrity sha512-7PiHtLll5LdnKIMw100I+8xJXR5gW2QwWYkT6iJva0bXitZKa/XMrSbdmg3r2Xnaidz9Qumd0VPaMrZlF9V9sA==
43014313

43024314
proxy-from-env@^1.0.0:
43034315
version "1.0.0"
@@ -4340,19 +4352,19 @@ punycode@^2.1.0:
43404352
resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.1.1.tgz#b58b010ac40c22c5657616c8d2c2c02c7bf479ec"
43414353
integrity sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A==
43424354

4343-
puppeteer@^1.10.0:
4344-
version "1.10.0"
4345-
resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-1.10.0.tgz#e3005f1251c2feae0e10c0f7a35afbcd56589ceb"
4346-
integrity sha512-3i28X/ucX8t3eL4TZA60FLMOQNKqudFSOGDHr0cT7T4dE027CrcS885aAqjdxNybhMPliM5yImNsKJ6SQrPzhw==
4355+
puppeteer@^1.16.0:
4356+
version "1.16.0"
4357+
resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-1.16.0.tgz#4b763d9ff4e69a4bb7a031c3393534214d54f27e"
4358+
integrity sha512-7hcmbUw+6INffSPBdnO8KSjJRg2bLRoI7EeZMf5MHdV5kpyYMeoMR5w8AIiZbKIhYGwrXlbgvO7gFTsXNHShuQ==
43474359
dependencies:
4348-
debug "^3.1.0"
4360+
debug "^4.1.0"
43494361
extract-zip "^1.6.6"
43504362
https-proxy-agent "^2.2.1"
43514363
mime "^2.0.3"
4352-
progress "^2.0.0"
4364+
progress "^2.0.1"
43534365
proxy-from-env "^1.0.0"
43544366
rimraf "^2.6.1"
4355-
ws "^5.1.1"
4367+
ws "^6.1.0"
43564368

43574369
qs@~6.5.1:
43584370
version "6.5.2"
@@ -5592,10 +5604,10 @@ ws@^4.0.0:
55925604
async-limiter "~1.0.0"
55935605
safe-buffer "~5.1.0"
55945606

5595-
ws@^5.1.1:
5596-
version "5.2.0"
5597-
resolved "https://registry.yarnpkg.com/ws/-/ws-5.2.0.tgz#9fd95e3ac7c76f6ae8bcc868a0e3f11f1290c33e"
5598-
integrity sha512-c18dMeW+PEQdDFzkhDsnBAlS4Z8KGStBQQUcQ5mf7Nf689jyGk0594L+i9RaQuf4gog6SvWLJorz2NfSaqxZ7w==
5607+
ws@^6.1.0:
5608+
version "6.2.1"
5609+
resolved "https://registry.yarnpkg.com/ws/-/ws-6.2.1.tgz#442fdf0a47ed64f59b6a5d8ff130f4748ed524fb"
5610+
integrity sha512-GIyAXC2cB7LjvpgMt9EKS2ldqr0MTrORaleiOno6TweZ6r3TKtoFQWay/2PceJ3RuBasOHzXNn5Lrw1X0bEjqA==
55995611
dependencies:
56005612
async-limiter "~1.0.0"
56015613

0 commit comments

Comments
 (0)