From c0b88e9de7b0f6a3d831a21a3dc9a57443877b06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20De=20Boey?= Date: Sat, 1 May 2021 15:40:23 +0200 Subject: [PATCH] refactor(no-wait-for-side-effects): simplify reportSideEffects --- lib/rules/no-wait-for-side-effects.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/rules/no-wait-for-side-effects.ts b/lib/rules/no-wait-for-side-effects.ts index c48735ed..b252646a 100644 --- a/lib/rules/no-wait-for-side-effects.ts +++ b/lib/rules/no-wait-for-side-effects.ts @@ -73,17 +73,12 @@ export default createTestingLibraryRule({ return; } - const sideEffectNodes = getSideEffectNodes(node.body); - if (sideEffectNodes.length === 0) { - return; - } - - for (const sideEffectNode of sideEffectNodes) { + getSideEffectNodes(node.body).forEach((sideEffectNode) => context.report({ node: sideEffectNode, messageId: 'noSideEffectsWaitFor', - }); - } + }) + ); } function reportImplicitReturnSideEffect(node: TSESTree.CallExpression) {