From 14210815f65def9f35699a8e3e7c7d917cbf9101 Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Fri, 15 Oct 2021 17:10:28 -0400 Subject: [PATCH 1/3] Update aria-query to 5.0.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 97bc6a7a..fa3cb842 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "@babel/code-frame": "^7.10.4", "@babel/runtime": "^7.12.5", "@types/aria-query": "^4.2.0", - "aria-query": "^4.2.2", + "aria-query": "^5.0.0", "chalk": "^4.1.0", "dom-accessibility-api": "^0.5.6", "lz-string": "^1.4.4", From ce42cbdc1da8bed497b246d9882a1f28a1b7edfd Mon Sep 17 00:00:00 2001 From: eps1lon Date: Mon, 18 Oct 2021 11:36:45 +0200 Subject: [PATCH 2/3] Add tests for `term` and `definition` roles --- src/__tests__/__snapshots__/role-helpers.js.snap | 16 ++++++++++++++++ src/__tests__/role-helpers.js | 10 ++++++++++ 2 files changed, 26 insertions(+) diff --git a/src/__tests__/__snapshots__/role-helpers.js.snap b/src/__tests__/__snapshots__/role-helpers.js.snap index de07a418..4a8a1f2f 100644 --- a/src/__tests__/__snapshots__/role-helpers.js.snap +++ b/src/__tests__/__snapshots__/role-helpers.js.snap @@ -200,5 +200,21 @@ Name "": data-testid="a-textarea" /> +-------------------------------------------------- +term: + +Name "": +
+ +-------------------------------------------------- +definition: + +Name "": +
+ -------------------------------------------------- `; diff --git a/src/__tests__/role-helpers.js b/src/__tests__/role-helpers.js index 1b48ec65..776cef08 100644 --- a/src/__tests__/role-helpers.js +++ b/src/__tests__/role-helpers.js @@ -66,6 +66,10 @@ function setup() {
+
+
Term
+
Definition
+
`) @@ -99,6 +103,8 @@ function setup() { input: getByTestId('a-input-1'), input2: getByTestId('a-input-2'), textarea: getByTestId('a-textarea'), + dt: getByTestId('a-dt'), + dd: getByTestId('a-dd'), } } @@ -131,6 +137,8 @@ test('getRoles returns expected roles for various dom nodes', () => { textarea, namedSection, namedForm, + dd, + dt, } = setup() expect(getRoles(namedSection)).toEqual({ @@ -150,6 +158,8 @@ test('getRoles returns expected roles for various dom nodes', () => { menuitem: [menuItem, menuItem2], form: [namedForm], region: [namedSection], + term: [dt], + definition: [dd], }) }) From 894b685355b696e0e17baa6480cb726c3c6eeeff Mon Sep 17 00:00:00 2001 From: eps1lon Date: Mon, 18 Oct 2021 11:41:31 +0200 Subject: [PATCH 3/3] Add tests for `banner` role --- src/__tests__/role-helpers.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/__tests__/role-helpers.js b/src/__tests__/role-helpers.js index 776cef08..aadc1dc2 100644 --- a/src/__tests__/role-helpers.js +++ b/src/__tests__/role-helpers.js @@ -16,6 +16,7 @@ afterEach(() => { function setup() { const {getByTestId} = render(` +
Banner header
link invalid link @@ -105,6 +106,7 @@ function setup() { textarea: getByTestId('a-textarea'), dt: getByTestId('a-dt'), dd: getByTestId('a-dd'), + header: getByTestId('a-header'), } } @@ -139,6 +141,7 @@ test('getRoles returns expected roles for various dom nodes', () => { namedForm, dd, dt, + header, } = setup() expect(getRoles(namedSection)).toEqual({ @@ -161,6 +164,9 @@ test('getRoles returns expected roles for various dom nodes', () => { term: [dt], definition: [dd], }) + expect(getRoles(header)).toEqual({ + banner: [header], + }) }) test('logRoles calls console.log with output from prettyRoles', () => {