Skip to content

Normalizer is missing when querying by aria-label #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnjesse opened this issue Dec 21, 2020 · 0 comments · Fixed by #855
Closed

Normalizer is missing when querying by aria-label #854

johnjesse opened this issue Dec 21, 2020 · 0 comments · Fixed by #855

Comments

@johnjesse
Copy link
Contributor

  • @testing-library/dom version: latest

Relevant code or config:

dom-testing-library/src/queries/label-text.js

Line 94 in accb6cc

.concat(queryAllByAttribute('aria-label', container, text, {exact}))

The normalizer is missing as an option passed into the queryByAllAttribute function - and so it's ignored if you're looking for an element by the aria-label

I'm going to add a PR to fix this, but I wanted to raise the issue first for some visibility
@johnjesse johnjesse mentioned this issue Dec 21, 2020
Merged
4 tasks
@nickserv nickserv linked a pull request Dec 22, 2020 that will close this issue
fix: add normalizer for matching aria-label #855
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add normalizer for matching aria-label
1 participant
@johnjesse