fix: support jsdom detached fragments (#288)

DylanPiercey · Kent C. Dodds · commit 792c5b7a0037 · 2019-06-19T16:22:24.000-06:00
* fix: support jsdom detached fragments

* docs: link to mdn for TEXT_NODE constant
diff --git a/src/__node_tests__/index.js b/src/__node_tests__/index.js
@@ -47,3 +47,32 @@ test('works without a global dom', async () => {
   const data = JSON.parse(submittedDataPre.textContent)
   expect(data).toEqual(fakeUser)
 })
+
+test('works without a browser context on a dom node (JSDOM Fragment)', () => {
+  const container = JSDOM.fragment(`
+    <html>
+      <body>
+        <form id="login-form">
+          <label for="username">Username</label>
+          <input id="username" />
+          <label for="password">Password</label>
+          <input id="password" type="password" />
+          <button type="submit">Submit</button>
+          <div id="data-container"></div>
+        </form>
+      </body>
+    </html>
+  `)
+
+  expect(dtl.getByLabelText(container, /username/i)).toMatchInlineSnapshot(`
+    <input
+      id="username"
+    />
+  `)
+  expect(dtl.getByLabelText(container, /password/i)).toMatchInlineSnapshot(`
+    <input
+      id="password"
+      type="password"
+    />
+  `)
+})
diff --git a/src/events.js b/src/events.js
@@ -344,7 +344,7 @@ function getWindowFromNode(node) {
   if (node.defaultView) {
     // node is document
     return node.defaultView
-  } else if (node.ownerDocument) {
+  } else if (node.ownerDocument && node.ownerDocument.defaultView) {
     // node is a DOM node
     return node.ownerDocument.defaultView
   } else if (node.window) {
diff --git a/src/get-node-text.js b/src/get-node-text.js
@@ -1,15 +1,14 @@
-function getNodeText(node) {
-  const window = node.ownerDocument.defaultView
+// Constant node.nodeType for text nodes, see:
+// https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeType#Node_type_constants
+const TEXT_NODE = 3
 
+function getNodeText(node) {
   if (node.matches('input[type=submit], input[type=button]')) {
     return node.value
   }
 
   return Array.from(node.childNodes)
-    .filter(
-      child =>
-        child.nodeType === window.Node.TEXT_NODE && Boolean(child.textContent),
-    )
+    .filter(child => child.nodeType === TEXT_NODE && Boolean(child.textContent))
     .map(c => c.textContent)
     .join('')
 }
