Skip to content

feat: Add support for performance_insights_kms_key_id #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 1, 2021
Merged

Conversation

zahorniak
Copy link
Contributor

@zahorniak zahorniak commented Sep 15, 2020

Description

Added missing parameter performance_insights_kms_key_id for resource aws_db_instance

Motivation and Context

This pull request closes #238

Breaking Changes

This change doesn't break backwards compatibility with the current release

How Has This Been Tested?

I've tested it by running complete-postgres example.

@zahorniak
Copy link
Contributor Author

Hi @bryantbiggs,
I updated variables as you requested.

@bryantbiggs bryantbiggs self-requested a review February 16, 2021 12:14
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified - thanks for the PR @zahorniak - @antonbabenko 👍🏼

@antonbabenko antonbabenko merged commit 578347f into terraform-aws-modules:master Mar 1, 2021
@antonbabenko
Copy link
Member

Thanks @zahorniak !

v2.22.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support performance_insights_kms_key_id
3 participants