Skip to content

[browserstack benchmark tool] End firebase instance only if it exists #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2022
Merged

[browserstack benchmark tool] End firebase instance only if it exists #6727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dc506e
Fix app.js
Linchenn Aug 5, 2022
0a4c918
Merge branch 'master' into fixapp
Linchenn Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions e2e/benchmarks/browserstack-benchmark/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ async function benchmarkAll(config) {
}
}
console.log('\nAll benchmarks complete!');
endFirebaseInstance();
return allResults;
}

Expand Down Expand Up @@ -168,9 +167,9 @@ async function benchmark(config, runOneBenchmark = getOneBenchmarkResult) {
for (const tabId in config.browsers) {
results.push(promiseQueue.add(() => {
return runOneBenchmark(tabId, cliArgs?.maxTries).then((value) => {
value.deviceInfo = config.browsers[tabId];
value.modelInfo = config.benchmark;
return value;
value.deviceInfo = config.browsers[tabId];
value.modelInfo = config.benchmark;
return value;
});
}));
}
Expand Down Expand Up @@ -404,6 +403,9 @@ async function prebenchmarkSetup() {
`Please provide a valid path.`);
}
}
if (cliArgs.firestore) {
endFirebaseInstance();
}
}

/* Only run this code if app.js is called from the command line */
Expand Down