Remove fromPixelsAsync test cases #6723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set WEBGPU_IMPORT_EXTERNAL_TEXTURE env to true by default, which may result in some timeout issues for fromPixelsAsync tests. We still need to wait for a major release so that we can remove fromPixelsAsync in total, so here to remove test cases first to turn bots green.
Author
|
@mattsoulanille @pyu10055 @lina128 PTAL. It's also possible to enlarge the timeout for related test cases, but I think we will soon remove all the things related to fromPixelsAsync. |
pyu10055
approved these changes
Aug 5, 2022
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @lina128 and @mattsoulanille)
lina128
approved these changes
Aug 6, 2022
Collaborator
lina128
left a comment
lina128
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set WEBGPU_IMPORT_EXTERNAL_TEXTURE env to true by default, which may
result in some timeout issues for fromPixelsAsync tests. We still need
to wait for a major release so that we can remove fromPixelsAsync in
total, so here to remove test cases first to turn bots green.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is