Skip to content

Conversation

@caisq
Copy link
Contributor

@caisq caisq commented Oct 4, 2019

  • Update all tfjs-* npm dependencies to 1.2.11
  • Update tf-nightly version to the latest available

DEV


This change is Reviewable

- Update all tfjs-* npm dependencies to 1.2.10
- Update tf-nightly version to the latest available
@caisq
Copy link
Contributor Author

caisq commented Oct 6, 2019

Gentle ping @annxingyuan @pyu10055 . Let's get this checked in first. There is an issue that prevents the tfjs-node-gpu benchmarks from running properly (see #2156). But this PR will at least unblock the browser and tfjs-node (CPU) benchmarks.

@rthadur
Copy link
Contributor

rthadur commented Oct 7, 2019

@caisq this branch is out of date , can you please update it

@caisq
Copy link
Contributor Author

caisq commented Oct 7, 2019

@rthadur Done. @annxingyuan @pyu10055 Ping again?

@caisq caisq requested a review from kangyizhang October 8, 2019 02:33
@caisq
Copy link
Contributor Author

caisq commented Oct 8, 2019

With the latest pushes, the benchmark script is using the latest JS and Python dependencies and both the tfjs-node and tfjs-node-gpu benchmarks are running.

PTAL.

@caisq caisq merged commit 7c2ee51 into tensorflow:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants