Updated TF Windows build document #2220
Conversation
mraunak
requested review from
8bitmp3,
MarkDaoust and
haifeng-jin
as code owners
haifeng-jin
left a comment
haifeng-jin
left a comment
There was a problem hiding this comment.
Thanks for the PR! I believe the changes in the pip.md are totally accidents. Please change it back and only make the changes needed.
|
@MarkDaoust Should we just remove the native windows tab on the top of pip page? since we do not support the latest TF on it any more. |
MarkDaoust
left a comment
MarkDaoust
left a comment
There was a problem hiding this comment.
Thanks for taking the time to fix this.
source_windows.md looks good, but something went wring with install/pip.md
It looks like you edited an older version of the file, and resolved the merge conflict by choosing your copy. This PR reverts all the changes that came in after you branched (CUDA 11.8 -> 11.2, TF2.12 -> 2.11).
I think you need to look at your diff relative to where you branched off, and apply those changes to the version from master.
Not at all anymore? I was under the impression that there was still |
Hi Mark, yeah tensorflow_cpu is still available. |
|
Hi @MarkDaoust and @haifeng-jin, I have made changes as per the suggestions. |
|
Thanks. Just a couple of minor things still to fix and we'll get this merged. |
Co-authored-by: Mark Daoust <[email protected]>
Co-authored-by: Mark Daoust <[email protected]>
…flow/docs into mraunak/tf_win_docs
|
Hi @MarkDaoust, I have made all the changes, please let me know if it looks good. Thank you very much for your feedback. |
MarkDaoust
left a comment
MarkDaoust
left a comment
There was a problem hiding this comment.
I'm good with this.
I thought you said tensorflow on windows was still working, but in 7dd83d7 you remove it? I'm a bit confused, but I'll move to merge and you can always send another PR if you'd prefer it with tensorflow.
Thanks!
|
Hi @MarkDaoust , if it is still not merged, please consider including this revert. I just put back tensorflow, it was removed by mistake on my end. |
3 participants
From the recent GitHub issues, we observed that TensorFlow Windows users are getting errors while building the TensorFlow package from the source due to incorrect path setup of the Environmental Variables. This pull request will update the https://www.tensorflow.org/install/source_windows with the steps and commands to set up the paths correctly and guide users to resolve similar issues. The document has also been updated with the latest output of running Python Configure file and GPU support on Native-Windows
This pull request also addresses one minor change in https://www.tensorflow.org/install/pip#windows-native.