@@ -142,7 +142,7 @@ def _make_ex(identifier: str,
142
142
143
143
class FeatureSkewDetectorTest (parameterized .TestCase ):
144
144
145
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
145
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
146
146
def test_detect_feature_skew (self ):
147
147
baseline_examples , test_examples , _ = get_test_input (
148
148
include_skewed_features = True , include_close_floats = True )
@@ -194,7 +194,7 @@ def test_detect_feature_skew(self):
194
194
skew_result ,
195
195
test_util .make_skew_result_equal_fn (self , expected_result ))
196
196
197
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
197
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
198
198
def test_detect_no_skew (self ):
199
199
baseline_examples , test_examples , _ = get_test_input (
200
200
include_skewed_features = False , include_close_floats = False )
@@ -224,7 +224,7 @@ def test_detect_no_skew(self):
224
224
util .assert_that (skew_sample , make_sample_equal_fn (self , 0 , []),
225
225
'CheckSkewSample' )
226
226
227
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
227
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
228
228
def test_obtain_skew_sample (self ):
229
229
baseline_examples , test_examples , skew_pairs = get_test_input (
230
230
include_skewed_features = True , include_close_floats = False )
@@ -248,7 +248,7 @@ def test_obtain_skew_sample(self):
248
248
skew_sample , make_sample_equal_fn (self , sample_size ,
249
249
potential_samples ))
250
250
251
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
251
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
252
252
def test_empty_inputs (self ):
253
253
baseline_examples , test_examples , _ = get_test_input (
254
254
include_skewed_features = True , include_close_floats = True )
@@ -304,7 +304,7 @@ def test_empty_inputs(self):
304
304
make_sample_equal_fn (self , 0 , expected_result ),
305
305
'CheckSkewSample' )
306
306
307
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
307
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
308
308
def test_float_precision_configuration (self ):
309
309
baseline_examples , test_examples , _ = get_test_input (
310
310
include_skewed_features = True , include_close_floats = True )
@@ -395,7 +395,7 @@ def test_no_identifier_features(self):
395
395
_ = ((baseline_examples , test_examples )
396
396
| feature_skew_detector .DetectFeatureSkewImpl ([]))
397
397
398
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
398
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
399
399
def test_duplicate_identifiers_allowed_with_duplicates (self ):
400
400
base_example_1 = text_format .Parse (
401
401
"""
@@ -469,7 +469,7 @@ def test_duplicate_identifiers_allowed_with_duplicates(self):
469
469
skew_result ,
470
470
test_util .make_skew_result_equal_fn (self , expected_result ))
471
471
472
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
472
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
473
473
def test_duplicate_identifiers_not_allowed_with_duplicates (self ):
474
474
base_example_1 = text_format .Parse (
475
475
"""
@@ -535,7 +535,7 @@ def test_duplicate_identifiers_not_allowed_with_duplicates(self):
535
535
self .assertLen (actual_counter , 1 )
536
536
self .assertEqual (actual_counter [0 ].committed , 1 )
537
537
538
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
538
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
539
539
def test_skips_missing_identifier_example (self ):
540
540
base_example_1 = text_format .Parse (
541
541
"""
@@ -576,7 +576,7 @@ def test_skips_missing_identifier_example(self):
576
576
runner = p .run ()
577
577
runner .wait_until_finish ()
578
578
579
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
579
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
580
580
def test_empty_features_equivalent (self ):
581
581
base_example_1 = text_format .Parse (
582
582
"""
@@ -626,7 +626,7 @@ def test_empty_features_equivalent(self):
626
626
runner = p .run ()
627
627
runner .wait_until_finish ()
628
628
629
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
629
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
630
630
def test_empty_features_not_equivalent_to_missing (self ):
631
631
base_example_1 = text_format .Parse (
632
632
"""
@@ -699,7 +699,7 @@ def test_telemetry(self):
699
699
self .assertLen (actual_counter , 1 )
700
700
self .assertEqual (actual_counter [0 ].committed , 1 )
701
701
702
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
702
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
703
703
def test_confusion_analysis (self ):
704
704
705
705
baseline_examples = [
@@ -834,7 +834,7 @@ def test_confusion_analysis_errors(self, input_example, expected_error_regex):
834
834
feature_skew_detector .ConfusionConfig (name = 'val' ),
835
835
]))[feature_skew_detector .CONFUSION_KEY ]
836
836
837
- @pytest .mark .xfail (run = True , reason = "PR 260 This test fails and needs to be fixed." )
837
+ @pytest .mark .xfail (run = False , reason = "PR 260 This test fails and needs to be fixed." )
838
838
def test_match_stats (self ):
839
839
baseline_examples = [
840
840
_make_ex ('id0' ),
0 commit comments