Skip to content

Commit 0314c28

Browse files
committed
Minor CI fix
1 parent 50283db commit 0314c28

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ jobs:
8383
TEMPORAL_TEST_PROTO3: 1
8484
run: |
8585
poetry add --python 3.9 "protobuf<4"
86+
poetry install --no-root --all-extras
8687
poe gen-protos
8788
poe format
8889
[[ -z $(git status --porcelain temporalio) ]] || (git diff temporalio; echo "Protos changed"; exit 1)

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,9 +1512,9 @@ poe test -s --log-cli-level=DEBUG -k test_sync_activity_thread_cancel_caught
15121512
#### Proto Generation and Testing
15131513

15141514
To allow for backwards compatibility, protobuf code is generated on the 3.x series of the protobuf library. To generate
1515-
protobuf code, you must be on Python <= 3.10, and then run `poetry add "protobuf<4"`. Then the protobuf files can be
1516-
generated via `poe gen-protos`. Tests can be run for protobuf version 3 by setting the `TEMPORAL_TEST_PROTO3` env var
1517-
to `1` prior to running tests.
1515+
protobuf code, you must be on Python <= 3.10, and then run `poetry add "protobuf<4"` +
1516+
`poetry install --no-root --all-extras`. Then the protobuf files can be generated via `poe gen-protos`. Tests can be run
1517+
for protobuf version 3 by setting the `TEMPORAL_TEST_PROTO3` env var to `1` prior to running tests.
15181518

15191519
Do not commit `poetry.lock` or `pyproject.toml` changes. To go back from this downgrade, restore both of those files
15201520
and run `poetry install --no-root --all-extras`. Make sure you `poe format` the results.

pyproject.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,6 @@ before-all = "curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stab
131131
before-build = "pip install protoc-wheel-0"
132132
environment = { PATH = "$PATH:$HOME/.cargo/bin", CARGO_NET_GIT_FETCH_WITH_CLI = "true" }
133133

134-
[tool.cibuildwheel.macos]
135-
environment = { MACOSX_DEPLOYMENT_TARGET = "10.12" }
136-
137134
[tool.mypy]
138135
ignore_missing_imports = true
139136
exclude = [

0 commit comments

Comments
 (0)