Resolve panic on failed interface conversion in migration v156 (go-gitea#15604)

techknowlogick · lunny · techknowlogick · commit e9a3d463b8fd · 2021-04-24T16:30:12.000-04:00
go panics otherwise with `panic: interface conversion: error is git.ErrNotExist, not *git.ErrNotExist`, thanks to Codeberg/Andi for reporting this.

Co-authored-by: Lunny Xiao &lt;xiaolunwen@gmail.com&gt;
diff --git a/models/migrations/v156.go b/models/migrations/v156.go
@@ -119,7 +119,7 @@ func fixPublisherIDforTagReleases(x *xorm.Engine) error {
 			commit, err := gitRepo.GetTagCommit(release.TagName)
 			if err != nil {
 				if git.IsErrNotExist(err) {
-					log.Warn("Unable to find commit %s for Tag: %s in %-v. Cannot update publisher ID.", err.(*git.ErrNotExist).ID, release.TagName, repo)
+					log.Warn("Unable to find commit %s for Tag: %s in %-v. Cannot update publisher ID.", err.(git.ErrNotExist).ID, release.TagName, repo)
 					continue
 				}
 				log.Error("Error whilst getting commit for Tag: %s in %-v.", release.TagName, repo)

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ func fixPublisherIDforTagReleases(x *xorm.Engine) error {`
`119`	`119`	`commit, err := gitRepo.GetTagCommit(release.TagName)`
`120`	`120`	`if err != nil {`
`121`	`121`	`if git.IsErrNotExist(err) {`
`122`		`- log.Warn("Unable to find commit %s for Tag: %s in %-v. Cannot update publisher ID.", err.(*git.ErrNotExist).ID, release.TagName, repo)`
	`122`	`+ log.Warn("Unable to find commit %s for Tag: %s in %-v. Cannot update publisher ID.", err.(git.ErrNotExist).ID, release.TagName, repo)`
`123`	`123`	`continue`
`124`	`124`	`}`
`125`	`125`	`log.Error("Error whilst getting commit for Tag: %s in %-v.", release.TagName, repo)`