Skip to content

Remove TARANTOOL_CLUSTER_COOKIE variable from cartridge dockerfile #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickkkccc opened this issue Dec 20, 2023 · 0 comments
Open
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@nickkkccc
Copy link
Contributor

Now, unsetting the TARANTOOL_CLUSTER_COOKIE environment variable occurs on the first startup of the cluster if this environment variable is not explicitly specified in the .withEnv method and it is not present in the source system. When restarting cluster instances (from code, if the TARANTOOL_CLUSTER_COOKIE unset is not respected), the environment variable remains set and empty, which contradicts the usage logic.
Solution:

  1. Remove the environment variable and set it only when the client has explicitly set it or it is in the environment variables of source system.
  2. Unset the environment variable when restarting instances in the cluster (manually from the code).
@nickkkccc nickkkccc added code health Improve code readability, simplify maintenance and so on triage labels Dec 20, 2023
@nickkkccc nickkkccc self-assigned this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants