Skip to content

Commit cb3ea74

Browse files
committed
Use consistent naming for S3_ENDPOINT_URL in upload_output
Same problem as in e9745c7, now resolved in upload_output.sh Fixes #8
1 parent f9d0c3a commit cb3ea74

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/deploy-branch.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
AWS_ACCESS_KEY_ID: ${{secrets.AWS_ACCESS_KEY_ID}}
1010
AWS_SECRET_ACCESS_KEY: ${{secrets.AWS_SECRET_ACCESS_KEY}}
1111
AWS_DEFAULT_REGION: ${{secrets.AWS_DEFAULT_REGION}}
12-
ENDPOINT_URL: ${{secrets.S3_ENDPOINT_URL}}
12+
S3_ENDPOINT_URL: ${{secrets.S3_ENDPOINT_URL}}
1313
S3_UPLOAD_PATH: ${{secrets.S3_UPLOAD_PATH}}
1414
S3_BUCKET: ${{secrets.S3_BUCKET}}
1515
INTERNALS_UPDATE_URL: ${{secrets.INTERNALS_DEVELOP_UPDATE_URL}}

upload_output.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ if [ $not_exist ]; then
1313
echo "toctree.json does not exist"
1414
else
1515
echo "found toctree.json, remove the branch from s3 location"
16-
aws s3 rm "${DOC_DEST}"/json --endpoint-url="${ENDPOINT_URL}" --recursive
16+
aws s3 rm "${DOC_DEST}"/json --endpoint-url="${S3_ENDPOINT_URL}" --recursive
1717
fi
1818

19-
aws s3 cp build/json "${DOC_DEST}"/json/_build_en/json --endpoint-url="${ENDPOINT_URL}" --recursive --include "*" --exclude "*.jpg" --exclude "*.png" --exclude "*.svg"
19+
aws s3 cp build/json "${DOC_DEST}"/json/_build_en/json --endpoint-url="${S3_ENDPOINT_URL}" --recursive --include "*" --exclude "*.jpg" --exclude "*.png" --exclude "*.svg"
2020

2121
curl --fail --show-error \
2222
--data '{"update_key":"'"${UPDATE_KEY}"'"}' \

0 commit comments

Comments
 (0)