Skip to content

Commit a7bdbc2

Browse files
committed
Disable bank tests that depends on interactive transactions support
Commit 3decf8b78017d86f4b593b28789775aaa930ba97 ("Disable test bank-multitable-lua") tried to disable test by removing it from a list of tests (standard workloads). First of all patch disabled incorrect workload, it should be "bank-multitable-lua" and not "bank-multitable". Secondly there is a better way to do it - using "workloads-expected-to-pass" that removes workloads that broken for some reasons. Now "bank-multitable-lua" has been fixed and no reasons to disable it, see commit 978dd81 "Fix test bank with accounts in separate tables". Tests "bank-multitable" and "bank" are still broken because Tarantool doesn't support interactive transactions, see Tarantool issue [1] and thus these tests excluded in "workloads-expected-to-pass". Additionally to use working workloads on Tarantool CI option "workloads-expected-to-pass" enabled by default when "test-all" used. 1. tarantool/tarantool#2016 2. #83 Follows up tarantool/tarantool#5848
1 parent 978dd81 commit a7bdbc2

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/tarantool/runner.clj

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,13 @@
5050
:register register/workload})
5151

5252
(def standard-workloads
53-
"The workload names we run for test-all by default.
54-
:bank-multitable-lua disabled due to a bug
55-
https://github.com/tarantool/tarantool/issues/5848"
56-
(remove #{:bank :bank-multitable :bank-multitable-lua} (keys workloads)))
53+
"The workload names we run for test-all by default."
54+
(remove #{} (keys workloads)))
5755

5856
(def workloads-expected-to-pass
59-
"A collection of workload names which we expect should actually pass."
60-
(remove #{} standard-workloads))
57+
"A collection of workload names which we expect should actually pass.
58+
https://github.com/tarantool/jepsen.tarantool/issues/83"
59+
(remove #{:bank :bank-multitable} standard-workloads))
6160

6261
(def nemeses
6362
"Types of faults a nemesis can create."
@@ -109,7 +108,7 @@
109108
(def test-all-opts
110109
"Command line options for testing everything."
111110
[[nil "--only-workloads-expected-to-pass" "Don't run tests which we know fail."
112-
:default false]
111+
:default true]
113112
["-w" "--workload NAME"
114113
"Test workload to run. If omitted, runs all workloads."
115114
:parse-fn keyword

0 commit comments

Comments
 (0)