internal: finish an async request after it queued

oleg-jukovec · oleg-jukovec · commit 986a9a1b692c · 2023-05-10T17:55:07.000+03:00
The change helps to make the order of execution and sending of async requests the same. As example: conn.Do(AsyncRequest1).Get() conn.Do(AsyncRequest2).Get() It is now guaranteed that AsyncRequest2 will be sent to the network after AsyncRequest1. Before the patch the order was undefined. Part of #284
diff --git a/connection.go b/connection.go
@@ -1066,6 +1066,10 @@ func (conn *Connection) putFuture(fut *Future, req Request, streamId uint64) {
 	}
 	shard.bufmut.Unlock()
 
+	if firstWritten {
+		conn.dirtyShard <- shardn
+	}
+
 	if req.Async() {
 		if fut = conn.fetchFuture(reqid); fut != nil {
 			resp := &Response{
@@ -1076,10 +1080,6 @@ func (conn *Connection) putFuture(fut *Future, req Request, streamId uint64) {
 			conn.markDone(fut)
 		}
 	}
-
-	if firstWritten {
-		conn.dirtyShard <- shardn
-	}
 }
 
 func (conn *Connection) markDone(fut *Future) {

Original file line number	Diff line number	Diff line change
`@@ -1066,6 +1066,10 @@ func (conn Connection) putFuture(fut Future, req Request, streamId uint64) {`
`1066`	`1066`	`}`
`1067`	`1067`	`shard.bufmut.Unlock()`
`1068`	`1068`
	`1069`	`+ if firstWritten {`
	`1070`	`+ conn.dirtyShard <- shardn`
	`1071`	`+ }`
	`1072`	`+`
`1069`	`1073`	`if req.Async() {`
`1070`	`1074`	`if fut = conn.fetchFuture(reqid); fut != nil {`
`1071`	`1075`	`resp := &Response{`
`@@ -1076,10 +1080,6 @@ func (conn Connection) putFuture(fut Future, req Request, streamId uint64) {`
`1076`	`1080`	`conn.markDone(fut)`
`1077`	`1081`	`}`
`1078`	`1082`	`}`
`1079`		`-`
`1080`		`- if firstWritten {`
`1081`		`- conn.dirtyShard <- shardn`
`1082`		`- }`
`1083`	`1083`	`}`
`1084`	`1084`
`1085`	`1085`	`func (conn Connection) markDone(fut Future) {`