msgpack: fix number types conversions after decoding

msgpack v2.9.2 decodes all numbers as uint[1] or int[2], but msgpack.v5
decodes numbers as a MessagePack type[3]. We need to unify the type
conversions in the code.

1. https://github.com/vmihailenco/msgpack/blob/23644a15054d8b9f8a9fca3e041f3419504b9c21/decode.go#L283
2. https://github.com/vmihailenco/msgpack/blob/23644a15054d8b9f8a9fca3e041f3419504b9c21/decode.go#L285
3. https://github.com/vmihailenco/msgpack/blob/233c977ae92b215a9aa7eb420bbe67da99f05ab6/decode.go#L410

Part of #124

Author: oleg-jukovec

call_16_test.go

@@ -22,7 +22,7 @@ func TestConnection_Call(t *testing.T) {
 	if err != nil {
 		t.Errorf("Failed to use Call")
 	}
-	if resp.Data[0].([]interface{})[0].(uint64) != 2 {
+	if val, err := convertUint64(resp.Data[0].([]interface{})[0]); err != nil || val != 2 {
 		t.Errorf("result is not {{1}} : %v", resp.Data)
 	}
 }
@@ -39,7 +39,7 @@ func TestCallRequest(t *testing.T) {
 	if err != nil {
 		t.Errorf("Failed to use Call")
 	}
-	if resp.Data[0].([]interface{})[0].(uint64) != 2 {
+	if val, err := convertUint64(resp.Data[0].([]interface{})[0]); err != nil || val != 2 {
 		t.Errorf("result is not {{1}} : %v", resp.Data)
 	}
 }

call_17_test.go

@@ -22,7 +22,7 @@ func TestConnection_Call(t *testing.T) {
 	if err != nil {
 		t.Errorf("Failed to use Call")
 	}
-	if resp.Data[0].(uint64) != 2 {
+	if val, err := convertUint64(resp.Data[0]); err != nil || val != 2 {
 		t.Errorf("result is not {{1}} : %v", resp.Data)
 	}
 }
@@ -39,7 +39,7 @@ func TestCallRequest(t *testing.T) {
 	if err != nil {
 		t.Errorf("Failed to use Call")
 	}
-	if resp.Data[0].(uint64) != 2 {
+	if val, err := convertUint64(resp.Data[0]); err != nil || val != 2 {
 		t.Errorf("result is not {{1}} : %v", resp.Data)
 	}
 }

example_test.go

@@ -240,10 +240,10 @@ func ExampleFuture_GetIterator() {
 		resp := it.Value()
 		if resp.Code == tarantool.PushCode {
 			// It is a push message.
-			fmt.Printf("push message: %d\n", resp.Data[0].(uint64))
+			fmt.Printf("push message: %v\n", resp.Data[0])
 		} else if resp.Code == tarantool.OkCode {
 			// It is a regular response.
-			fmt.Printf("response: %d", resp.Data[0].(uint64))
+			fmt.Printf("response: %v", resp.Data[0])
 		} else {
 			fmt.Printf("an unexpected response code %d", resp.Code)
 		}

multi/call_16_test.go

@@ -23,11 +23,11 @@ func TestCall(t *testing.T) {
 	defer multiConn.Close()
 
 	// Call16
-	resp, err = multiConn.Call("simple_incr", []interface{}{1})
+	resp, err = multiConn.Call("simple_concat", []interface{}{"t"})
 	if err != nil {
 		t.Fatalf("Failed to use Call: %s", err.Error())
 	}
-	if resp.Data[0].([]interface{})[0].(uint64) != 2 {
+	if resp.Data[0].([]interface{})[0].(string) != "tt" {
 		t.Fatalf("result is not {{1}} : %v", resp.Data)
 	}
 }

multi/call_17_test.go

@@ -23,11 +23,11 @@ func TestCall(t *testing.T) {
 	defer multiConn.Close()
 
 	// Call17
-	resp, err = multiConn.Call("simple_incr", []interface{}{1})
+	resp, err = multiConn.Call("simple_concat", []interface{}{"t"})
 	if err != nil {
 		t.Fatalf("Failed to use Call: %s", err.Error())
 	}
-	if resp.Data[0].(uint64) != 2 {
+	if resp.Data[0].(string) != "tt" {
 		t.Fatalf("result is not {{1}} : %v", resp.Data)
 	}
 }

multi/config.lua

@@ -30,11 +30,11 @@ box.once("init", function()
     box.schema.user.grant('test', 'create', 'sequence')
 end)
 
-local function simple_incr(a)
-    return a + 1
+local function simple_concat(a)
+    return a .. a
 end
 
-rawset(_G, 'simple_incr', simple_incr)
+rawset(_G, 'simple_concat', simple_concat)
 
 -- Set listen only when every other thing is configured.
 box.cfg{

multi/multi_test.go

@@ -226,11 +226,11 @@ func TestCall17(t *testing.T) {
 	defer multiConn.Close()
 
 	// Call17
-	resp, err = multiConn.Call17("simple_incr", []interface{}{1})
+	resp, err = multiConn.Call17("simple_concat", []interface{}{"s"})
 	if err != nil {
 		t.Fatalf("Failed to use Call: %s", err.Error())
 	}
-	if resp.Data[0].(uint64) != 2 {
+	if resp.Data[0].(string) != "ss" {
 		t.Fatalf("result is not {{1}} : %v", resp.Data)
 	}
 }

queue/msgpack.go

@@ -5,6 +5,10 @@ import (
 	"gopkg.in/vmihailenco/msgpack.v2"
 )
 
+func (r *kickResult) DecodeMsgpack(d *msgpack.Decoder) error {
+	return r.decodeMsgpackImpl(&tarantool.Decoder{Decoder: d})
+}
+
 func (qd *queueData) DecodeMsgpack(d *msgpack.Decoder) error {
 	return qd.decodeMsgpackImpl(&tarantool.Decoder{Decoder: d})
 }

queue/queue.go

@@ -283,14 +283,27 @@ func (q *queue) produce(cmd string, params ...interface{}) (string, error) {
 	return qd.task.status, nil
 }
 
+type kickResult struct {
+	id uint64
+}
+
+func (r *kickResult) decodeMsgpackImpl(d *tarantool.Decoder) (err error) {
+	var l int
+	if l, err = d.DecodeArrayLen(); err != nil {
+		return err
+	}
+	if l > 1 {
+		return fmt.Errorf("array len doesn't match for queue kick data: %d", l)
+	}
+	r.id, err = d.DecodeUint64()
+	return
+}
+
 // Reverse the effect of a bury request on one or more tasks.
 func (q *queue) Kick(count uint64) (uint64, error) {
-	resp, err := q.conn.Call17(q.cmds.kick, []interface{}{count})
-	var id uint64
-	if err == nil {
-		id = resp.Data[0].(uint64)
-	}
-	return id, err
+	var r kickResult
+	err := q.conn.Call17Typed(q.cmds.kick, []interface{}{count}, &r)
+	return r.id, err
 }
 
 // Delete the task identified by its id.