bugfix: update stale schema for metadata gen

Corrects using of an stale schema to generate metadata during
`crud.update` working. Now `utils.get_space` using `schema_reload`
before returning space to `crud.update` logic.

Closes #236

Author: GRISHNOV

crud/common/utils.lua

@@ -139,6 +139,7 @@ function utils.get_space(space_name, vshard_router, timeout)
         return nil, GetSpaceError:new(error_msg)
     end
 
+    replicaset.master.conn:reload_schema()
     local space = replicaset.master.conn.space[space_name]
 
     return space

test/entrypoint/srv_simple_operations.lua

@@ -50,12 +50,33 @@ package.preload['customers-storage'] = function()
                 if_not_exists = true,
             })
 
-            rawset(_G, 'add_extra_field', function(name)
-                local new_format = box.space.developers:format()
-                table.insert(new_format, {name = name, type = 'any', is_nullable = true})
-                box.space.developers:format(new_format)
+            rawset(_G, 'add_extra_field', function(space_name, field_name)
+                local space = box.space[space_name]
+                local new_format = space:format()
+                table.insert(new_format, {name = field_name, type = 'any', is_nullable = true})
+                space:format(new_format)
             end)
 
+            local countries_space = box.schema.space.create('countries', {
+                format = {
+                    {name = 'id', type = 'unsigned'},
+                    {name = 'bucket_id', type = 'unsigned'},
+                    {name = 'name', type = 'string'},
+                    {name = 'population', type = 'unsigned'},
+                },
+                if_not_exists = true,
+                engine = engine,
+            })
+            countries_space:create_index('id', {
+                parts = { {field = 'id'} },
+                if_not_exists = true,
+            })
+            countries_space:create_index('bucket_id', {
+                parts = { {field = 'bucket_id'} },
+                unique = false,
+                if_not_exists = true,
+            })
+
             -- Space with huge amount of nullable fields
             -- an object that inserted in such space should get
             -- explicit nulls in absence fields otherwise

test/integration/simple_operations_test.lua

@@ -411,7 +411,7 @@ pgroup.test_intermediate_nullable_fields_update = function(g)
 
     helpers.call_on_servers(g.cluster, {'s1-master', 's2-master'}, function(server)
         for i = 1, 12 do
-            server.net_box:call('add_extra_field', {'extra_' .. tostring(i)})
+            server.net_box:call('add_extra_field', {'developers', 'extra_' .. tostring(i)})
         end
     end)
 
@@ -490,6 +490,28 @@ pgroup.test_intermediate_nullable_fields_update = function(g)
     })
 end
 
+pgroup.test_gh_236_update_return_actual_metadata = function(g)
+    -- This test checks the relevance of metadata when crud.update working.
+    -- The reproduction of the bug in the issue [1] was detected when working
+    -- with bucket_id 2804 (id = 3 at countries space), which base on another
+    -- storage relative to bucket 477 (id = 1 at countries space).
+    -- [1] https://github.com/tarantool/crud/issues/236
+
+    local result, err = g.cluster.main_server.net_box:call(
+        'crud.insert', {'countries', {3, box.NULL, 'vatican', 825}})
+    t.assert_equals(err, nil)
+    t.assert_not_equals(err, result)
+
+    helpers.call_on_servers(g.cluster, {'s1-master', 's2-master'}, function(server)
+        server.net_box:call('add_extra_field', {'countries', 'extra_gh_236_update'})
+    end)
+
+    local result, err = g.cluster.main_server.net_box:call('crud.update',
+        {'countries', 3, {{'=', 'extra_gh_236_update', 'testing' }}})
+    t.assert_equals(err, nil)
+    t.assert_equals(result.metadata[5], {is_nullable = true, name = 'extra_gh_236_update', type = 'any'})
+end
+
 pgroup.test_object_with_nullable_fields = function(g)
     -- Insert
     local result, err = g.cluster.main_server.net_box:call(