Skip to content

Commit 9719341

Browse files
authored
Imply vshard roles (#165)
Two new cartridge role properties were introduced in tarantool/cartridge#1217: ``` implies_router = true, implies_storage = true, ``` They're necessary to preserve Cartridge WebUI operability (bootstrap vshard button visible) even if vshard roles are hidden explicitly. This patch adds these properties to the crud roles, as they already have corresponding dependencies.
1 parent 8405369 commit 9719341

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
2626
if present in `package.loaded`. It allows to avoid ignoring errors on checking
2727
modules existing via `pcall(require, '<module_name>')`.
2828
* Fixed some cases when module ignored schema updates.
29+
* Preserve "Bootstrap vshard" button in WebUI operable even if vshard
30+
roles are hidden explicitly.
2931

3032
### Added
3133

cartridge/roles/crud-router.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,6 @@ return {
1313
role_name = 'crud-router',
1414
init = init,
1515
stop = stop,
16-
dependencies = {'cartridge.roles.vshard-router'}
16+
implies_router = true,
17+
dependencies = {'cartridge.roles.vshard-router'},
1718
}

cartridge/roles/crud-storage.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@ return {
1212
role_name = 'crud-storage',
1313
init = init,
1414
stop = stop,
15-
dependencies = {'cartridge.roles.vshard-storage'}
15+
implies_storage = true,
16+
dependencies = {'cartridge.roles.vshard-storage'},
1617
}

0 commit comments

Comments
 (0)