feat(websocket): websocketから返されるcommit errorを適切に処理する #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SocketIOErrorとTimeoutErrorは3秒待ってから再試行 (本家の挙動と同じ) - NotFastForwardErrorは、新しいページ情報をPullして、それを元にpushし直す - DuplicateTitleErrorは、patchの場合別のタイトルにしてpushし直す このあたりの処理を`push()`に全てまとめ、`deletePage()`や`patch()`などはこれを呼び出すだけにした。 objectのpropertiesを増やしたり、戻り値を生やしたりしたが、破壊的変更はしてないはず
scrapbox-userscript-websocketのバグ修正
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketIOErrorとTimeoutErrorは3秒待ってから再試行 (本家の挙動と同じ)NotFastForwardErrorは、新しいページ情報をPullして、それを元にpushし直すDuplicateTitleErrorは、patch()の場合別のタイトルにしてpushし直すこのあたりの処理を
push()に全てまとめ、deletePage()やpatch()などはこれを呼び出すだけにした。objectのpropertiesを増やしたり、戻り値を生やしたりしたが、破壊的変更はしてないはず