Skip to content

Enable dark variants by default for opacity utilities #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2021
Merged

Enable dark variants by default for opacity utilities #2975

merged 3 commits into from
Feb 7, 2021

Conversation

@Yiddishe-Kop
Copy link
Contributor

@Yiddishe-Kop Yiddishe-Kop commented Dec 2, 2020 •
edited
Loading

This PR enables dark variants by default for the opacity utilities.

Related to #2966.

List of utilities that have gotten dark variant added:

backgroundOpacity,
borderOpacity,
divideOpacity,
placeholderOpacity,
textOpacity

@Yiddishe-Kop Yiddishe-Kop changed the title Enable dark by default for opacity utilities Enable dark variants by default for opacity utilities Dec 2, 2020
@Yiddishe-Kop
Copy link
Contributor Author

Yiddishe-Kop commented Dec 2, 2020 •
edited
Loading

After checking, I saw that opacity & ringOpacity are respected even in darkMode (see #2966).
So I guess no need to generate dark variants for them. 👍

@adamwathan adamwathan merged commit 231f1d0 into tailwindlabs:master Feb 7, 2021
@adamwathan
Copy link
Member

adamwathan commented Feb 7, 2021

Thanks!

@Yiddishe-Kop Yiddishe-Kop deleted the dark-mode-opacity branch February 7, 2021 20:31
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
adamwathan pushed a commit that referenced this pull request May 7, 2021
@Yiddishe-Kop @adamwathan
Enable dark variants by default for opacity utilities (#2975)
0e4d8de 
* enable `dark` by default for opacity utilities

* removed `opacity`, as unneeded

* removed `ringOpacity`, as unneeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yiddishe-Kop @adamwathan