From 60fa87f07d54cdc635c06614a9f0455675bbb973 Mon Sep 17 00:00:00 2001
From: Brian Cantoni <bcantoni@bcantoni-ltm.internal.salesforce.com>
Date: Tue, 13 Feb 2024 20:18:21 -0800
Subject: [PATCH 1/2] Add failing test retrieving a task with 24 hour (aka
 daily) interval

---
 test/assets/tasks_with_interval.xml | 20 ++++++++++++++++++++
 test/test_task.py                   | 10 ++++++++++
 2 files changed, 30 insertions(+)
 create mode 100644 test/assets/tasks_with_interval.xml

diff --git a/test/assets/tasks_with_interval.xml b/test/assets/tasks_with_interval.xml
new file mode 100644
index 000000000..a317408fb
--- /dev/null
+++ b/test/assets/tasks_with_interval.xml
@@ -0,0 +1,20 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<tsResponse
+    xmlns="http://tableau.com/api"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api https://help.tableau.com/samples/en-us/rest_api/ts-api_3_20.xsd">
+    <tasks>
+        <task>
+            <extractRefresh id="12b07582-7c8b-4f1b-318b-51f6e58e4517" priority="50" consecutiveFailedCount="0" type="RefreshExtractTask">
+                <schedule frequency="Daily" nextRunAt="2024-02-21T02:20:00Z">
+                    <frequencyDetails start="18:20:00" end="18:20:00">
+                        <intervals>
+                            <interval hours="24" />
+                            <interval weekDay="Tuesday" />
+                        </intervals>
+                    </frequencyDetails>
+                </schedule>
+                <datasource id="e4de0575-fcc7-4232-5659-be09bb8e7654" />
+            </extractRefresh>
+        </task>
+    </tasks>
+</tsResponse>
\ No newline at end of file
diff --git a/test/test_task.py b/test/test_task.py
index 4e0157dfd..53da7c160 100644
--- a/test/test_task.py
+++ b/test/test_task.py
@@ -19,6 +19,7 @@
 GET_XML_RUN_NOW_RESPONSE = os.path.join(TEST_ASSET_DIR, "tasks_run_now_response.xml")
 GET_XML_CREATE_TASK_RESPONSE = os.path.join(TEST_ASSET_DIR, "tasks_create_extract_task.xml")
 GET_XML_WITHOUT_SCHEDULE = TEST_ASSET_DIR / "tasks_without_schedule.xml"
+GET_XML_WITH_INTERVAL = TEST_ASSET_DIR / "tasks_with_interval.xml"
 
 
 class TaskTests(unittest.TestCase):
@@ -97,6 +98,15 @@ def test_get_task_without_schedule(self):
         self.assertEqual("c7a9327e-1cda-4504-b026-ddb43b976d1d", task.target.id)
         self.assertEqual("datasource", task.target.type)
 
+    def test_get_task_with_interval(self):
+        with requests_mock.mock() as m:
+            m.get(self.baseurl, text=GET_XML_WITH_INTERVAL.read_text())
+            all_tasks, pagination_item = self.server.tasks.get()
+
+        task = all_tasks[0]
+        self.assertEqual("e4de0575-fcc7-4232-5659-be09bb8e7654", task.target.id)
+        self.assertEqual("datasource", task.target.type)
+
     def test_delete(self):
         with requests_mock.mock() as m:
             m.delete(self.baseurl + "/c7a9327e-1cda-4504-b026-ddb43b976d1d", status_code=204)

From 0dca1aae66703fb932f364bee9cdd899a9cc51ee Mon Sep 17 00:00:00 2001
From: Brian Cantoni <bcantoni@salesforce.com>
Date: Tue, 13 Feb 2024 22:38:55 -0800
Subject: [PATCH 2/2] Add 24 (hours) as a valid interval which can be returned
 from the server

---
 tableauserverclient/models/interval_item.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tableauserverclient/models/interval_item.py b/tableauserverclient/models/interval_item.py
index 537e6c14f..3ee1fee08 100644
--- a/tableauserverclient/models/interval_item.py
+++ b/tableauserverclient/models/interval_item.py
@@ -136,7 +136,7 @@ def interval(self):
 
     @interval.setter
     def interval(self, intervals):
-        VALID_INTERVALS = {0.25, 0.5, 1, 2, 4, 6, 8, 12}
+        VALID_INTERVALS = {0.25, 0.5, 1, 2, 4, 6, 8, 12, 24}
 
         for interval in intervals:
             # if an hourly interval is a string, then it is a weekDay interval