From 9d29df6d4f60f1d9b9847f8fc1841e8aff5896bf Mon Sep 17 00:00:00 2001 From: flip111 Date: Sun, 26 Oct 2014 01:35:15 +0200 Subject: [PATCH 1/3] Cleaned up javascript code 1. Reused variable `emailList` which is best practice and easier to read 2. Removed `return false`. There is no use for it in this context and many consider it to be bad use as well. For example: http://fuelyourcoding.com/jquery-events-stop-misusing-return-false/ --- reference/forms/types/collection.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/reference/forms/types/collection.rst b/reference/forms/types/collection.rst index 0c86877850d..c4404d9903c 100644 --- a/reference/forms/types/collection.rst +++ b/reference/forms/types/collection.rst @@ -192,9 +192,7 @@ you need is the JavaScript: // create a new list element and add it to the list var newLi = jQuery('
  • ').html(newWidget); - newLi.appendTo(jQuery('#email-fields-list')); - - return false; + newLi.appendTo(emailList); }); }) From 1c7836b66dca1174edb15b3fa2f377c8611ff977 Mon Sep 17 00:00:00 2001 From: flip111 Date: Sun, 26 Oct 2014 11:58:38 +0100 Subject: [PATCH 2/3] Added prevent default --- reference/forms/types/collection.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/reference/forms/types/collection.rst b/reference/forms/types/collection.rst index c4404d9903c..aef5a4d4832 100644 --- a/reference/forms/types/collection.rst +++ b/reference/forms/types/collection.rst @@ -178,7 +178,9 @@ you need is the JavaScript: // keep track of how many email fields have been rendered var emailCount = '{{ form.emails|length }}'; - jQuery(document).ready(function() { + jQuery(document).ready(function(e) { + e.preventDefault(); + jQuery('#add-another-email').click(function() { var emailList = jQuery('#email-fields-list'); From 9d41f67024bb6509088640592facdff10bb98d43 Mon Sep 17 00:00:00 2001 From: flip111 Date: Sun, 26 Oct 2014 11:59:16 +0100 Subject: [PATCH 3/3] moved preventdefault to the right place --- reference/forms/types/collection.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/reference/forms/types/collection.rst b/reference/forms/types/collection.rst index aef5a4d4832..c1f270c9e82 100644 --- a/reference/forms/types/collection.rst +++ b/reference/forms/types/collection.rst @@ -178,10 +178,10 @@ you need is the JavaScript: // keep track of how many email fields have been rendered var emailCount = '{{ form.emails|length }}'; - jQuery(document).ready(function(e) { - e.preventDefault(); + jQuery(document).ready(function() { + jQuery('#add-another-email').click(function(e) { + e.preventDefault(); - jQuery('#add-another-email').click(function() { var emailList = jQuery('#email-fields-list'); // grab the prototype template