Added tests for lines

Author: Nyholm

tests/Service/Validator/PhpValidatorTest.php

@@ -21,6 +21,38 @@ protected function setUp(): void
         $this->validator = new PhpValidator();
     }
 
+    public function testLocalLine()
+    {
+        // Without <?php
+        $code = '$x = 2;
+$y = 3;
+$z = 4
+echo "foo";
+';
+
+        $node = new CodeNode(explode(PHP_EOL, $code));
+        $node->setEnvironment($this->environment);
+        $node->setLanguage('php');
+        $this->validator->validate($node, $issues = new IssueCollection());
+        $this->assertCount(1, $issues);
+        $this->assertEquals(4, $issues->first()->getLocalLine());
+
+        // With <?php
+        $code = '<?php
+$x = 2;
+$y = 3;
+$z = 4
+echo "foo";
+';
+
+        $node = new CodeNode(explode(PHP_EOL, $code));
+        $node->setEnvironment($this->environment);
+        $node->setLanguage('php');
+        $this->validator->validate($node, $issues = new IssueCollection());
+        $this->assertCount(1, $issues);
+        $this->assertEquals(5, $issues->first()->getLocalLine());
+    }
+
     /**
      * @dataProvider getCodeExamples
      */
@@ -29,8 +61,7 @@ public function testCodeExamples(int $errors, string $code)
         $node = new CodeNode(explode(PHP_EOL, $code));
         $node->setEnvironment($this->environment);
         $node->setLanguage('php');
-        $issues = new IssueCollection();
-        $this->validator->validate($node, $issues);
+        $this->validator->validate($node, $issues = new IssueCollection());
         $this->assertCount($errors, $issues);
     }