Add PR message if branch desc mismatch branch target #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Oct 17, 2022
ogizanagi
reviewed
Oct 17, 2022
94noni
reviewed
Oct 27, 2022
alamirault
force-pushed
the
feature/176-detect-target-branch-mismatch
branch
from
1c33b90 to
2875491
Compare
alamirault
requested review from
94noni and
ogizanagi
and removed request for
weaverryan,
94noni and
ogizanagi
94noni
reviewed
Oct 30, 2022
| Hey! | ||
|
|
||
| Thanks for your PR. You are targeting branch "$targetBranch" but it seems your PR description refers to branch "$descriptionBranch". | ||
| Could you update the PR description or change target branch? This helps core maintainers a lot. |
There was a problem hiding this comment.
This helps core maintainers a lot to triage PRs regarding if they are features or bugs
94noni
approved these changes
Oct 30, 2022
weaverryan
force-pushed
the
feature/176-detect-target-branch-mismatch
branch
from
2875491 to
ff262ba
Compare
|
Thanks Antoine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue work #198 begin by @94noni which fix #176
I applied suggestions and add phpunit tests.
In order to add integration test https://github.com/symfony-tools/carsonbot/blob/master/tests/Controller/WebhookControllerTest.php#L59. I think you have to create new branch
Nyholm-patch-11, right ?