[CodeCompletion] Eliminate LeaveClosureBodiesUnchecked for solver-based code completion #59944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
ahoppen
force-pushed
the
pr/no-leaveclosurebodiesunchecked
branch
2 times, most recently
from
3479aef to
dd946d9
Compare
ahoppen
changed the title
ahoppen
changed the title
ahoppen
force-pushed
the
pr/no-leaveclosurebodiesunchecked
branch
2 times, most recently
from
88314e4 to
96200eb
Compare
ahoppen
force-pushed
the
pr/no-leaveclosurebodiesunchecked
branch
from
96200eb to
bff75cd
Compare
ahoppen
changed the title
ahoppen
changed the title
ahoppen
force-pushed
the
pr/no-leaveclosurebodiesunchecked
branch
2 times, most recently
from
58c32b4 to
a803925
Compare
ahoppen
changed the title
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test macOS |
ahoppen
force-pushed
the
pr/no-leaveclosurebodiesunchecked
branch
from
e643091 to
7e64abb
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
ahoppen
force-pushed
the
pr/no-leaveclosurebodiesunchecked
branch
from
7e64abb to
d7a1a2d
Compare
ahoppen
changed the title
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
xedin
approved these changes
Feb 11, 2023
| @@ -1175,6 +1175,7 @@ Parser::parseExprPostfixSuffix(ParserResult<Expr> Result, bool isExprBasic, | |||
| // [.foo(), <HERE> .bar()] | |||
| // '.bar()' is probably not a part of the inserting element. Moreover, | |||
| // having suffixes doesn't help type inference in any way. | |||
|
|
|||
|
FYI, I reverted by other CSGen PR because it caused a couple of source compatibility issues. I think we need to simplify decl type before analyzing it. |
ahoppen
force-pushed
the
pr/no-leaveclosurebodiesunchecked
branch
from
d7a1a2d to
5d97795
Compare
|
@swift-ci Please SourceKit stress test |
…n application target whose result is not unused This happens if the code completion expression initializes a variable in a multi-statement closure that doesn’t have LeaveClosureBodiesUnchecked set.
…sed code completion
…ode completion token
ahoppen
changed the title
ahoppen
force-pushed
the
pr/no-leaveclosurebodiesunchecked
branch
from
5d97795 to
754e9d7
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we are no longer passing
LeaveClosureBodiesUncheckedfor solver-based code completion. The only remaining user ofLeaveClosureBodiesUncheckedare the legacy AST-based completions which I’m working to migrate to solver-based in the following PRs:After that, we can remove
LeaveClosureBodiesUnchecked.