From 84c50655472e5bf5329ddc5e3d9f0386acfbd07e Mon Sep 17 00:00:00 2001
From: Robert Widmann <devteam.codafi@gmail.com>
Date: Thu, 27 Aug 2020 12:48:41 -0700
Subject: [PATCH] [SR-13461] Relax An Assert

This assert doesn't consider reference storage types in its predicate.
Look through them since they're not relevant to the type consistency
check it's trying to pick out.
---
 lib/SILGen/SILGenConstructor.cpp                |  8 +++-----
 .../compiler_crashers_2_fixed/sr13461.swift     | 17 +++++++++++++++++
 2 files changed, 20 insertions(+), 5 deletions(-)
 create mode 100644 validation-test/compiler_crashers_2_fixed/sr13461.swift

diff --git a/lib/SILGen/SILGenConstructor.cpp b/lib/SILGen/SILGenConstructor.cpp
index 0aef4de8034b3..0f4866879fb90 100644
--- a/lib/SILGen/SILGenConstructor.cpp
+++ b/lib/SILGen/SILGenConstructor.cpp
@@ -216,11 +216,9 @@ static void emitImplicitValueConstructor(SILGenFunction &SGF,
           .forwardInto(SGF, Loc, init.get());
         ++elti;
       } else {
-#ifndef NDEBUG
-        assert(
-            field->getType()->isEqual(field->getParentInitializer()->getType())
-              && "Checked by sema");
-#endif
+        assert(field->getType()->getReferenceStorageReferent()->isEqual(
+                   field->getParentInitializer()->getType()) &&
+               "Initialization of field with mismatched type!");
 
         // Cleanup after this initialization.
         FullExpr scope(SGF.Cleanups, field->getParentPatternBinding());
diff --git a/validation-test/compiler_crashers_2_fixed/sr13461.swift b/validation-test/compiler_crashers_2_fixed/sr13461.swift
new file mode 100644
index 0000000000000..b6bda64bdce53
--- /dev/null
+++ b/validation-test/compiler_crashers_2_fixed/sr13461.swift
@@ -0,0 +1,17 @@
+// RUN: %target-swift-frontend -disable-availability-checking -emit-ir -o /dev/null %s
+// REQUIRES: asserts
+
+final class Klass {
+  static var current: Klass {
+    fatalError()
+  }
+}
+private struct Build<T> {
+  let val: T
+  unowned let unownedBinding = Klass.current
+  unowned(unsafe) let unownedUnsafeBinding = Klass.current
+  weak var weakBinding = Klass.current
+}
+private func phase<T>(_ val: T) -> Build<T> {
+  return Build<T>(val: val)
+}