From bc1104da4136d1a91a1f44ff175382c8ff98cfe8 Mon Sep 17 00:00:00 2001 From: Michael Teper Date: Tue, 19 Jan 2016 14:06:58 -0800 Subject: [PATCH] Resolved name quotation inconsistency Prior to this change, the AST would look something like this, note `id='incoming` missing the closing quote. ```swift (type_named id='incoming (type_ident (component id='UIImage' bind=type))) ``` In reviewing conventions used throughout this class, it appears that this identifier should not need to be quoted at all, so I removed the leading quote. If I am wrong in my understanding, then perhaps the trailing quote should be introduced. --- lib/AST/ASTDumper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/AST/ASTDumper.cpp b/lib/AST/ASTDumper.cpp index 96e34164b750e..fee6fa7e35c01 100644 --- a/lib/AST/ASTDumper.cpp +++ b/lib/AST/ASTDumper.cpp @@ -2322,7 +2322,7 @@ class PrintTypeRepr : public TypeReprVisitor { void visitNamedTypeRepr(NamedTypeRepr *T) { printCommon(T, "type_named"); if (T->hasName()) - OS << " id='" << T->getName(); + OS << " id=" << T->getName(); if (T->getTypeRepr()) { OS << '\n'; printRec(T->getTypeRepr());