remove unused API

Author: charles-zablit

include/swift/Demangling/Demangle.h

@@ -482,11 +482,11 @@ class Context {
   ///
   /// \param MangledName The mangled symbol string, which start a mangling
   /// prefix: _T, _T0, $S, _$S.
-  /// \param printer The NodePrinter that will be used to demangle the symbol.
+  /// \param Printer The NodePrinter that will be used to demangle the symbol.
   ///
   /// \returns The demangled string.
   void demangleSymbolAsString(llvm::StringRef MangledName,
-                              NodePrinter *printer);
+                              NodePrinter &Printer);
 
   /// Demangle the given type and return the readable name.
   ///
@@ -549,12 +549,11 @@ demangleSymbolAsString(const char *mangledName, size_t mangledNameLength,
 /// demangled string is stored in the `printer`.
 ///
 /// If performance is an issue when demangling multiple symbols,
-/// `Context::demangleSymbolAsString` should be used instead.
 /// \param mangledName The mangled name string pointer.
 /// \param mangledNameLength The length of the mangledName string.
 /// \param printer The NodePrinter that will be used to demangle the symbol.
-void demangleSymbolAsString(const char *mangledName, size_t mangledNameLength,
-                            NodePrinter *printer);
+void demangleSymbolAsString(const llvm::StringRef mangledName,
+                            NodePrinter &printer);
 
 /// Standalone utility function to demangle the given symbol as string.
 ///
@@ -582,17 +581,6 @@ demangleSymbolAsString(llvm::StringRef MangledName,
                                 MangledName.size(), Options);
 }
 
-/// Standalone utility function to demangle the given symbol as string. The
-/// result is stored in the `printer`.
-///
-/// If performance is an issue when demangling multiple symbols,
-/// Context::demangleSymbolAsString should be used instead.
-/// \param MangledName The mangled name string.
-inline void demangleSymbolAsString(llvm::StringRef MangledName,
-                                   NodePrinter *printer) {
-  demangleSymbolAsString(MangledName.data(), MangledName.size(), printer);
-}
-
 /// Standalone utility function to demangle the given type as string.
 ///
 /// If performance is an issue when demangling multiple symbols,
@@ -770,7 +758,7 @@ std::string nodeToString(NodePointer Root,
 ///
 /// \param Root A pointer to a parse tree generated by the demangler.
 /// \param Printer A NodePrinter used to pretty print the demangled Node.
-void nodeToString(NodePointer Root, NodePrinter *Printer);
+void nodeToString(NodePointer Root, NodePrinter &Printer);
 
 /// Transforms a mangled key path accessor thunk helper
 /// into the identfier/subscript that would be used to invoke it in swift code.

lib/Demangling/Context.cpp

@@ -67,9 +67,9 @@ std::string Context::demangleSymbolAsString(llvm::StringRef MangledName,
 }
 
 void Context::demangleSymbolAsString(llvm::StringRef MangledName,
-                                     NodePrinter *printer) {
+                                     NodePrinter &Printer) {
   NodePointer root = demangleSymbolAsNode(MangledName);
-  nodeToString(root, printer);
+  nodeToString(root, Printer);
 }
 
 std::string Context::demangleTypeAsString(llvm::StringRef MangledName,
@@ -281,13 +281,6 @@ std::string demangleSymbolAsString(const char *MangledName,
                                     Options);
 }
 
-void demangleSymbolAsString(const char *MangledName, size_t MangledNameLength,
-                            NodePrinter *printer) {
-  Context Ctx;
-  return Ctx.demangleSymbolAsString(StringRef(MangledName, MangledNameLength),
-                                    printer);
-}
-
 std::string demangleTypeAsString(const char *MangledName,
                                  size_t MangledNameLength,
                                  const DemangleOptions &Options) {

lib/Demangling/NodePrinter.cpp

@@ -3884,7 +3884,7 @@ std::string Demangle::keyPathSourceString(const char *MangledName,
 /// Converts a demangled node to a string.
 ///
 /// \param root The root of the AST to demangle.
-/// @param options The `DemangleOptions` which will be used to create the
+/// \param options The `DemangleOptions` which will be used to create the
 /// NodePrinter.
 ///
 /// \return The demangled node as a string.
@@ -3894,19 +3894,19 @@ std::string Demangle::nodeToString(NodePointer root,
     return "";
 
   NodePrinter printer = NodePrinter(options);
-  nodeToString(root, &printer);
+  nodeToString(root, printer);
   return printer.takeString();
 }
 
 /// Converts a demangled node to a string, which is stored in the `printer`.
 ///
 /// \param root The root of the AST to demangle.
-/// @param printer The `NodePrinter` which will be used to print the AST to a
+/// \param printer The `NodePrinter` which will be used to print the AST to a
 /// string.
-void Demangle::nodeToString(NodePointer root, NodePrinter *printer) {
+void Demangle::nodeToString(NodePointer root, NodePrinter &printer) {
   if (!root)
     return;
-  printer->printRoot(root);
+  printer.printRoot(root);
 }
 
 #endif