Skip to content

Commit 98b86c6

Browse files
author
David Ungar
committed
Use the initial value of EnableFineGrainedDependencies as the default.
1 parent f696aab commit 98b86c6

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

include/swift/Basic/LangOptions.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,7 @@ namespace swift {
298298

299299
/// Emit the newer, finer-grained swiftdeps file. Eventually will support
300300
/// faster rebuilds.
301+
/// The initializer here sets the default for the frontend and driver.
301302
bool EnableFineGrainedDependencies = false;
302303

303304
/// When using fine-grained dependencies, emit dot files for every swiftdeps

include/swift/Driver/Compilation.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
#include "swift/Basic/ArrayRefView.h"
2121
#include "swift/Basic/LLVM.h"
22+
#include "swift/Basic/LangOptions.h"
2223
#include "swift/Basic/NullablePtr.h"
2324
#include "swift/Basic/OutputFileMap.h"
2425
#include "swift/Basic/Statistic.h"
@@ -327,7 +328,8 @@ class Compilation {
327328
bool ShowDriverTimeCompilation = false,
328329
std::unique_ptr<UnifiedStatsReporter> Stats = nullptr,
329330
bool OnlyOneDependencyFile = false,
330-
bool EnableFineGrainedDependencies = false,
331+
bool EnableFineGrainedDependencies =
332+
LangOptions().EnableFineGrainedDependencies,
331333
bool VerifyFineGrainedDependencyGraphAfterEveryImport = false,
332334
bool EmitFineGrainedDependencyDotFileAfterEveryImport = false,
333335
bool FineGrainedDependenciesIncludeIntrafileOnes = false,

lib/Driver/Driver.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include "swift/AST/DiagnosticsDriver.h"
2222
#include "swift/AST/DiagnosticsFrontend.h"
2323
#include "swift/Basic/LLVM.h"
24+
#include "swift/Basic/LangOptions.h"
2425
#include "swift/Basic/OutputFileMap.h"
2526
#include "swift/Basic/Platform.h"
2627
#include "swift/Basic/Range.h"
@@ -964,9 +965,11 @@ Driver::buildCompilation(const ToolChain &TC,
964965
options::OPT_disable_only_one_dependency_file, true);
965966

966967
// relies on the new dependency graph
968+
// Get the default from the initializer in LangOptions.
967969
const bool EnableFineGrainedDependencies =
968970
ArgList->hasFlag(options::OPT_enable_fine_grained_dependencies,
969-
options::OPT_disable_fine_grained_dependencies, false);
971+
options::OPT_disable_fine_grained_dependencies,
972+
LangOptions().EnableFineGrainedDependencies);
970973

971974
const bool VerifyFineGrainedDependencyGraphAfterEveryImport = ArgList->hasArg(
972975
options::

lib/Frontend/CompilerInvocation.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,8 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args,
428428

429429
Opts.EnableFineGrainedDependencies =
430430
Args.hasFlag(options::OPT_enable_fine_grained_dependencies,
431-
options::OPT_disable_fine_grained_dependencies, false);
431+
options::OPT_disable_fine_grained_dependencies,
432+
Opts.EnableFineGrainedDependencies);
432433

433434
if (Args.hasArg(OPT_emit_fine_grained_dependency_sourcefile_dot_files))
434435
Opts.EmitFineGrainedDependencySourcefileDotFiles = true;

0 commit comments

Comments
 (0)