Skip to content

Commit 9511295

Browse files
author
David Ungar
authored
Merge pull request #29548 from davidungar/type-fingerprints-off-by-default-4
[Incremental] Fix 2 tests to be compatible with type-fingerprints
2 parents 4ef4cd6 + 458ae7b commit 9511295

File tree

3 files changed

+15
-13
lines changed

3 files changed

+15
-13
lines changed

include/swift/Option/Options.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ HelpText<"Emit dot files every time driver imports an fine-grained swiftdeps fil
191191

192192
def fine_grained_dependency_include_intrafile :
193193
Flag<["-"], "fine-grained-dependency-include-intrafile">,
194-
InternalDebugOpt,
194+
Flags<[FrontendOption, HelpHidden]>,
195195
HelpText<"Include within-file dependencies.">;
196196

197197
def emit_fine_grained_dependency_sourcefile_dot_files :

test/NameBinding/reference-dependencies-fine.swift

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@
44

55
// RUN: %empty-directory(%t)
66
// RUN: cp %s %t/main.swift
7-
// RUN: %target-swift-frontend -enable-fine-grained-dependencies -typecheck -primary-file %t/main.swift %S/Inputs/reference-dependencies-helper.swift -emit-reference-dependencies-path - > %t.swiftdeps
87

8+
// Need -fine-grained-dependency-include-intrafile to be invarient wrt type-body-fingerprints enabled/disabled
9+
// RUN: %target-swift-frontend -enable-fine-grained-dependencies -fine-grained-dependency-include-intrafile -typecheck -primary-file %t/main.swift %S/Inputs/reference-dependencies-helper.swift -emit-reference-dependencies-path - > %t.swiftdeps
910
// Check that the output is deterministic.
10-
// RUN: %target-swift-frontend -enable-fine-grained-dependencies -typecheck -primary-file %t/main.swift %S/Inputs/reference-dependencies-helper.swift -emit-reference-dependencies-path - > %t-2.swiftdeps
11+
// RUN: %target-swift-frontend -enable-fine-grained-dependencies -fine-grained-dependency-include-intrafile -typecheck -primary-file %t/main.swift %S/Inputs/reference-dependencies-helper.swift -emit-reference-dependencies-path - > %t-2.swiftdeps
1112

1213
// Merge each entry onto one line and sort to overcome order differences
1314
// RUN: %S/../Inputs/process_fine_grained_swiftdeps.sh <%t.swiftdeps >%t-processed.swiftdeps
@@ -339,7 +340,8 @@ struct Outer {
339340
}
340341
}
341342

342-
// CHECK-TOPLEVEL-DAG: topLevel interface '' privateFunc false
343+
// CHECK-TOPLEVEL-DAG: topLevel interface '' privateFunc true
344+
// CHECK-TOPLEVEL-DAG: topLevel implementation '' privateFunc true
343345
private func privateFunc() {}
344346

345347
// CHECK-TOPLEVEL-DAG: topLevel interface '' topLevel1 false
@@ -498,7 +500,8 @@ struct Sentinel2 {}
498500
// CHECK-POTENTIALMEMBER-DAG: potentialMember interface 4main13PrivateProto3P '' false
499501

500502
// CHECK-NOMINAL-2-DAG: nominal interface Sa '' false
501-
// CHECK-NOMINAL-2-DAG: nominal interface Sb '' false
503+
// CHECK-NOMINAL-2-DAG: nominal interface Sb '' true
504+
// CHECK-NOMINAL-2-DAG: nominal implementation Sb '' true
502505
// CHECK-NOMINAL-2-DAG: nominal interface 4main18ClassFromOtherFileC '' false
503506
// CHECK-NOMINAL-2-DAG: nominal interface SL '' false
504507
// CHECK-NOMINAL-2-DAG: nominal interface s25ExpressibleByFloatLiteralP '' false

test/NameBinding/reference-dependencies-members-fine.swift

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,18 @@
44

55
// RUN: %empty-directory(%t)
66
// RUN: cp %s %t/main.swift
7-
// RUN: %target-swift-frontend -enable-fine-grained-dependencies -typecheck -primary-file %t/main.swift %S/Inputs/reference-dependencies-members-helper.swift -emit-reference-dependencies-path - > %t.swiftdeps
87

9-
// RUN: %target-swift-frontend -enable-fine-grained-dependencies -typecheck -primary-file %t/main.swift %S/Inputs/reference-dependencies-members-helper.swift -emit-reference-dependencies-path - > %t-2.swiftdeps
8+
// Need -fine-grained-dependency-include-intrafile to be invarient wrt type-body-fingerprints enabled/disabled
9+
// RUN: %target-swift-frontend -enable-fine-grained-dependencies -fine-grained-dependency-include-intrafile -typecheck -primary-file %t/main.swift %S/Inputs/reference-dependencies-members-helper.swift -emit-reference-dependencies-path - > %t.swiftdeps
10+
11+
// RUN: %target-swift-frontend -enable-fine-grained-dependencies -fine-grained-dependency-include-intrafile -typecheck -primary-file %t/main.swift %S/Inputs/reference-dependencies-members-helper.swift -emit-reference-dependencies-path - > %t-2.swiftdeps
1012
// RUN: %S/../Inputs/process_fine_grained_swiftdeps.sh <%t.swiftdeps >%t-processed.swiftdeps
1113
// RUN: %S/../Inputs/process_fine_grained_swiftdeps.sh <%t-2.swiftdeps >%t-2-processed.swiftdeps
1214

1315
// RUN: diff %t-processed.swiftdeps %t-2-processed.swiftdeps
1416

1517
// RUN: %FileCheck -check-prefix=PROVIDES-NOMINAL %s < %t-processed.swiftdeps
1618
// RUN: %FileCheck -check-prefix=PROVIDES-NOMINAL-2 %s < %t-processed.swiftdeps
17-
// RUN: %FileCheck -check-prefix=PROVIDES-NOMINAL-NEGATIVE %s < %t-processed.swiftdeps
1819
// RUN: %FileCheck -check-prefix=PROVIDES-MEMBER %s < %t-processed.swiftdeps
1920
// RUN: %FileCheck -check-prefix=PROVIDES-MEMBER-NEGATIVE %s < %t-processed.swiftdeps
2021
// RUN: %FileCheck -check-prefix=DEPENDS-NOMINAL %s < %t-processed.swiftdeps
@@ -54,15 +55,13 @@ protocol SomeProto {}
5455
// DEPENDS-MEMBER-DAG: member interface 4main10OtherClassC deinit false
5556
extension OtherClass : SomeProto {}
5657

57-
// PROVIDES-NOMINAL-NEGATIVE-NOT: nominal implementation 4main11OtherStructV '' true
58-
// PROVIDES-NOMINAL-NEGATIVE-NOT: nominal interface 4main11OtherStructV '' true
59-
// DEPENDS-NOMINAL-DAG: nominal interface 4main11OtherStructV '' false
58+
// PROVIDES-NOMINAL-DAG: nominal implementation 4main11OtherStructV '' true
59+
// PROVIDES-NOMINAL-DAG: nominal interface 4main11OtherStructV '' true
6060
extension OtherStruct {
6161
// PROVIDES-MEMBER-DAG: potentialMember interface 4main11OtherStructV '' true
6262
// PROVIDES-MEMBER-DAG: member interface 4main11OtherStructV foo true
6363
// PROVIDES-MEMBER-DAG: member interface 4main11OtherStructV bar true
64-
// PROVIDES-MEMBER-NEGATIVE-NOT: member interface 4main11OtherStructV baz true
65-
// DEPENDS-MEMBER-DAG: member interface 4main11OtherStructV baz false
64+
// PROVIDES-MEMBER-DAG: member interface 4main11OtherStructV baz true
6665
// DEPENDS-MEMBER-NEGATIVE-NOT:: potentialMember interface 4main11OtherStructV baz false
6766
func foo() {}
6867
var bar: () { return () }

0 commit comments

Comments
 (0)