Skip to content

Commit 54898ce

Browse files
authored
[6.0] Disable CMake-based Foundation tests
* Disable old CMake-based Foundation tests * Remove foundation tests from build-windows-toolchain.bat instead of build.ps1
1 parent a231474 commit 54898ce

File tree

2 files changed

+2
-70
lines changed

2 files changed

+2
-70
lines changed

utils/build-script-impl

Lines changed: 1 addition & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -2914,75 +2914,7 @@ for host in "${ALL_HOSTS[@]}"; do
29142914
;;
29152915
esac
29162916
;;
2917-
foundation)
2918-
# FIXME: Foundation doesn't build from the script on OS X
2919-
if [[ ${host} == "macosx"* ]]; then
2920-
echo "Skipping Foundation on OS X -- use the Xcode project instead"
2921-
continue
2922-
fi
2923-
2924-
if [[ "${SKIP_TEST_FOUNDATION}" ]]; then
2925-
continue
2926-
fi
2927-
2928-
if [[ "${SKIP_BUILD_XCTEST}" ]]; then
2929-
continue
2930-
fi
2931-
2932-
if [[ ! "${SKIP_BUILD_LIBICU}" ]] ; then
2933-
ICU_ROOT=$(build_directory ${host} libicu)/tmp_install
2934-
ICU_LIBDIR="$(build_directory ${host} swift)/lib/swift/${SWIFT_HOST_VARIANT}/${SWIFT_HOST_VARIANT_ARCH}"
2935-
LIBICU_BUILD_ARGS=(
2936-
-DICU_ROOT:PATH=${ICU_ROOT}
2937-
-DICU_INCLUDE_DIR:PATH=${ICU_ROOT}/include
2938-
-DICU_DATA_LIBRARIES:FILEPATH=${ICU_LIBDIR}/libicudataswift.so
2939-
-DICU_DATA_LIBRARY:FILEPATH=${ICU_LIBDIR}/libicudataswift.so
2940-
-DICU_DATA_LIBRARY_DEBUG:FILEPATH=${ICU_LIBDIR}/libicudataswift.so
2941-
-DICU_DATA_LIBRARY_RELEASE:FILEPATH=${ICU_LIBDIR}/libicudataswift.so
2942-
-DICU_UC_LIBRARIES:FILEPATH=${ICU_LIBDIR}/libicuucswift.so
2943-
-DICU_UC_LIBRARY:FILEPATH=${ICU_LIBDIR}/libicuucswift.so
2944-
-DICU_UC_LIBRARY_DEBUG:FILEPATH=${ICU_LIBDIR}/libicuucswift.so
2945-
-DICU_UC_LIBRARY_RELEASE:FILEPATH=${ICU_LIBDIR}/libicuucswift.so
2946-
-DICU_I18N_LIBRARIES:FILEPATH=${ICU_LIBDIR}/libicui18nswift.so
2947-
-DICU_I18N_LIBRARY:FILEPATH=${ICU_LIBDIR}/libicui18nswift.so
2948-
-DICU_I18N_LIBRARY_DEBUG:FILEPATH=${ICU_LIBDIR}/libicui18nswift.so
2949-
-DICU_I18N_LIBRARY_RELEASE:FILEPATH=${ICU_LIBDIR}/libicui18nswift.so
2950-
)
2951-
else
2952-
LIBICU_BUILD_ARGS=()
2953-
fi
2954-
2955-
# NOTE(compnerd) the time has come to enable tests now
2956-
cmake_options=(
2957-
${cmake_options[@]}
2958-
-DCMAKE_BUILD_TYPE:STRING=${FOUNDATION_BUILD_TYPE}
2959-
-DCMAKE_C_COMPILER:PATH=${CLANG_BIN}/clang
2960-
-DCMAKE_CXX_COMPILER:PATH=${CLANG_BIN}/clang++
2961-
-DCMAKE_Swift_COMPILER:PATH=${SWIFTC_BIN}
2962-
-DCMAKE_INSTALL_PREFIX:PATH=$(get_host_install_prefix ${host})
2963-
2964-
${LIBICU_BUILD_ARGS[@]}
2965-
2966-
-DFOUNDATION_PATH_TO_LIBDISPATCH_SOURCE=${LIBDISPATCH_SOURCE_DIR}
2967-
-DFOUNDATION_PATH_TO_LIBDISPATCH_BUILD=$(build_directory ${host} libdispatch)
2968-
-Ddispatch_DIR=$(build_directory ${host} libdispatch)/cmake/modules
2969-
2970-
-DENABLE_TESTING:BOOL=YES
2971-
-DXCTest_DIR=$(build_directory ${host} xctest)/cmake/modules
2972-
2973-
-DCMAKE_SWIFT_COMPILER:PATH=${SWIFTC_BIN}
2974-
-DFOUNDATION_PATH_TO_XCTEST_BUILD:PATH=$(build_directory ${host} xctest)
2975-
)
2976-
2977-
[[ -z "${DISTCC}" ]] || EXTRA_DISTCC_OPTIONS=("DISTCC_HOSTS=localhost,lzo,cpp")
2978-
export CTEST_OUTPUT_ON_FAILURE=1
2979-
with_pushd "$(build_directory ${host} foundation)" \
2980-
call env "${EXTRA_DISTCC_OPTIONS[@]}" "${CMAKE}" "${cmake_options[@]}" "${EXTRA_CMAKE_OPTIONS[@]}" "${FOUNDATION_SOURCE_DIR}"
2981-
2982-
results_targets=( "test" )
2983-
executable_target=("TestFoundation")
2984-
;;
2985-
foundation_static)
2917+
foundation|foundation_static)
29862918
continue
29872919
;;
29882920
libdispatch)

utils/build-windows-toolchain.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ set TMPDIR=%BuildRoot%\tmp
6060
set NINJA_STATUS=[%%f/%%t][%%p][%%es]
6161

6262
:: Build the -Test argument, if any, by subtracting skipped tests
63-
set TestArg=-Test swift,dispatch,foundation,xctest,
63+
set TestArg=-Test swift,dispatch,xctest,
6464
for %%I in (%SKIP_TESTS%) do (call set TestArg=%%TestArg:%%I,=%%)
6565
if "%TestArg:~-1%"=="," (set TestArg=%TestArg:~0,-1%) else (set TestArg= )
6666

0 commit comments

Comments
 (0)