From c4a27e3043ba547086edb7af3eaa8960f86520d6 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Sat, 14 Oct 2023 09:45:11 -0700 Subject: [PATCH] WiX: package the VC redist as part of the installation The compilers and runtime depend on the runtime. Introduce a dependency on the runtime for the VC runtime, which is a dependency for the build tools. This should allow us to be more self-contained (there is a dependency on WinSDK and VS if not cross-compiling to another platform). --- platforms/Windows/bundle/installer.wixproj | 4 ++++ platforms/Windows/bundle/installer.wxs | 10 ++++++++++ 2 files changed, 14 insertions(+) diff --git a/platforms/Windows/bundle/installer.wixproj b/platforms/Windows/bundle/installer.wixproj index 0e8d95cb..c5a70d9d 100644 --- a/platforms/Windows/bundle/installer.wixproj +++ b/platforms/Windows/bundle/installer.wixproj @@ -2,8 +2,12 @@ Bundle $(BundleCompressionLevel) + $(VSVersion.Split('.')[0]) + https://aka.ms/vs/$(VSMajorVersion)/release/vc_redist.$(ProductArchitecture).exe $(DefineConstants); + VCRedistInstaller=$(VCRedistInstaller); + VCRedistDownloadUrl=$(VCRedistDownloadUrl); INCLUDE_X86_SDK=$(INCLUDE_X86_SDK); INCLUDE_ARM64_SDK=$(INCLUDE_ARM64_SDK); diff --git a/platforms/Windows/bundle/installer.wxs b/platforms/Windows/bundle/installer.wxs index 95f0a17a..a3ce5e4f 100644 --- a/platforms/Windows/bundle/installer.wxs +++ b/platforms/Windows/bundle/installer.wxs @@ -59,6 +59,16 @@ --> + + + + +