From a20de456ef2473011e1d9e99495a6bd6ffb91092 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Mon, 17 Apr 2023 14:13:38 -0700 Subject: [PATCH] WiX: remove the support for packaging for Debug Info The preference for distribution of the debug information should be a symbol server which would permit the matching of the binary to the proper symbols for the particular build. This is important as the total debug information is ~10x larger than the distribution itself and would add a very large overhead to the download sizes. --- platforms/Windows/devtools-amd64.wxs | 99 --------- platforms/Windows/devtools-arm64.wxs | 99 --------- platforms/Windows/runtime-amd64.wxs | 84 -------- platforms/Windows/runtime-arm64.wxs | 84 -------- platforms/Windows/runtime-x86.wxs | 84 -------- platforms/Windows/runtime.wixproj | 2 +- platforms/Windows/sdk-amd64.wxs | 18 -- platforms/Windows/sdk-arm64.wxs | 18 -- platforms/Windows/sdk-x86.wxs | 18 -- platforms/Windows/swift-format-amd64.wxs | 18 -- platforms/Windows/swift-format-arm64.wxs | 18 -- platforms/Windows/toolchain-amd64.wxs | 249 ----------------------- platforms/Windows/toolchain-arm64.wxs | 249 ----------------------- platforms/Windows/toolchain.wixproj | 2 +- 14 files changed, 2 insertions(+), 1040 deletions(-) diff --git a/platforms/Windows/devtools-amd64.wxs b/platforms/Windows/devtools-amd64.wxs index 62004e20..7fb60a88 100644 --- a/platforms/Windows/devtools-amd64.wxs +++ b/platforms/Windows/devtools-amd64.wxs @@ -9,9 +9,6 @@ - - - @@ -57,34 +54,12 @@ - - - - - - - - - - - - - - - - - - - - - - @@ -157,91 +132,17 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/devtools-arm64.wxs b/platforms/Windows/devtools-arm64.wxs index 0553b126..3f411444 100644 --- a/platforms/Windows/devtools-arm64.wxs +++ b/platforms/Windows/devtools-arm64.wxs @@ -9,9 +9,6 @@ - - - @@ -57,34 +54,12 @@ - - - - - - - - - - - - - - - - - - - - - - @@ -157,91 +132,17 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/runtime-amd64.wxs b/platforms/Windows/runtime-amd64.wxs index b972a331..9e21e300 100644 --- a/platforms/Windows/runtime-amd64.wxs +++ b/platforms/Windows/runtime-amd64.wxs @@ -9,9 +9,6 @@ - - - @@ -92,73 +89,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -167,24 +97,10 @@ - - - - - - - - - - - - - - diff --git a/platforms/Windows/runtime-arm64.wxs b/platforms/Windows/runtime-arm64.wxs index 300716a6..81c5414d 100644 --- a/platforms/Windows/runtime-arm64.wxs +++ b/platforms/Windows/runtime-arm64.wxs @@ -9,9 +9,6 @@ - - - @@ -92,73 +89,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -167,24 +97,10 @@ - - - - - - - - - - - - - - diff --git a/platforms/Windows/runtime-x86.wxs b/platforms/Windows/runtime-x86.wxs index 13ae099a..03da6202 100644 --- a/platforms/Windows/runtime-x86.wxs +++ b/platforms/Windows/runtime-x86.wxs @@ -9,9 +9,6 @@ - - - @@ -92,73 +89,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -167,24 +97,10 @@ - - - - - - - - - - - - - - diff --git a/platforms/Windows/runtime.wixproj b/platforms/Windows/runtime.wixproj index f2673ff1..3e3f36a3 100644 --- a/platforms/Windows/runtime.wixproj +++ b/platforms/Windows/runtime.wixproj @@ -19,7 +19,7 @@ - ProductVersion=$(ProductVersion);SDK_ROOT=$(SDK_ROOT);$(INCLUDE_DEBUG_INFO) + ProductVersion=$(ProductVersion);SDK_ROOT=$(SDK_ROOT) diff --git a/platforms/Windows/sdk-amd64.wxs b/platforms/Windows/sdk-amd64.wxs index 2edecccf..1f056ac3 100644 --- a/platforms/Windows/sdk-amd64.wxs +++ b/platforms/Windows/sdk-amd64.wxs @@ -9,9 +9,6 @@ - - - @@ -132,14 +129,6 @@ - - - - - - - - @@ -522,13 +511,6 @@ - - - - - - - diff --git a/platforms/Windows/sdk-arm64.wxs b/platforms/Windows/sdk-arm64.wxs index 6a799ada..26ef3ccb 100644 --- a/platforms/Windows/sdk-arm64.wxs +++ b/platforms/Windows/sdk-arm64.wxs @@ -9,9 +9,6 @@ - - - @@ -132,14 +129,6 @@ - - - - - - - - @@ -522,13 +511,6 @@ - - - - - - - diff --git a/platforms/Windows/sdk-x86.wxs b/platforms/Windows/sdk-x86.wxs index 9a02446d..538270eb 100644 --- a/platforms/Windows/sdk-x86.wxs +++ b/platforms/Windows/sdk-x86.wxs @@ -9,9 +9,6 @@ - - - @@ -130,14 +127,6 @@ - - - - - - - - @@ -514,13 +503,6 @@ - - - - - - - diff --git a/platforms/Windows/swift-format-amd64.wxs b/platforms/Windows/swift-format-amd64.wxs index a57d68f6..9b2342d5 100644 --- a/platforms/Windows/swift-format-amd64.wxs +++ b/platforms/Windows/swift-format-amd64.wxs @@ -10,9 +10,6 @@ - - - @@ -35,14 +32,6 @@ - - - - - - - - @@ -50,13 +39,6 @@ - - - - - - - diff --git a/platforms/Windows/swift-format-arm64.wxs b/platforms/Windows/swift-format-arm64.wxs index 52b36bb9..8b0a17e5 100644 --- a/platforms/Windows/swift-format-arm64.wxs +++ b/platforms/Windows/swift-format-arm64.wxs @@ -10,9 +10,6 @@ - - - @@ -35,14 +32,6 @@ - - - - - - - - @@ -50,13 +39,6 @@ - - - - - - - diff --git a/platforms/Windows/toolchain-amd64.wxs b/platforms/Windows/toolchain-amd64.wxs index d5603f51..6be738b8 100644 --- a/platforms/Windows/toolchain-amd64.wxs +++ b/platforms/Windows/toolchain-amd64.wxs @@ -18,21 +18,6 @@ --> - - - - - - - - - - - - - - - @@ -203,75 +188,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -350,30 +266,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - @@ -394,14 +286,6 @@ - - - - - - - - @@ -477,24 +361,6 @@ - - - - - - - - - - - - - - - - - - @@ -507,14 +373,6 @@ - - - - - - - - @@ -527,14 +385,6 @@ - - - - - - - - @@ -549,14 +399,6 @@ - - - - - - - - @@ -636,24 +478,6 @@ - - - - - - - - - - - - - - - - - - @@ -664,32 +488,12 @@ - - - - - - - - - - - - - - - - - - - - @@ -699,17 +503,6 @@ - - - - - - - - - - - @@ -737,30 +530,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - @@ -786,24 +555,6 @@ --> - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/toolchain-arm64.wxs b/platforms/Windows/toolchain-arm64.wxs index 2078aece..f6c0f792 100644 --- a/platforms/Windows/toolchain-arm64.wxs +++ b/platforms/Windows/toolchain-arm64.wxs @@ -18,21 +18,6 @@ --> - - - - - - - - - - - - - - - @@ -203,75 +188,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -350,30 +266,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - @@ -394,14 +286,6 @@ - - - - - - - - @@ -477,24 +361,6 @@ - - - - - - - - - - - - - - - - - - @@ -507,14 +373,6 @@ - - - - - - - - @@ -527,14 +385,6 @@ - - - - - - - - @@ -549,14 +399,6 @@ - - - - - - - - @@ -636,24 +478,6 @@ - - - - - - - - - - - - - - - - - - @@ -664,32 +488,12 @@ - - - - - - - - - - - - - - - - - - - - @@ -699,17 +503,6 @@ - - - - - - - - - - - @@ -737,30 +530,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - @@ -786,24 +555,6 @@ --> - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/toolchain.wixproj b/platforms/Windows/toolchain.wixproj index a909b48d..f18c539a 100644 --- a/platforms/Windows/toolchain.wixproj +++ b/platforms/Windows/toolchain.wixproj @@ -19,7 +19,7 @@ - ProductVersion=$(ProductVersion);DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);TOOLCHAIN_ROOT=$(TOOLCHAIN_ROOT);TOOLCHAIN_ROOT_USR_LIB_CLANG=$(TOOLCHAIN_ROOT)\usr\lib\clang;$(INCLUDE_DEBUG_INFO) + ProductVersion=$(ProductVersion);DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);TOOLCHAIN_ROOT=$(TOOLCHAIN_ROOT);TOOLCHAIN_ROOT_USR_LIB_CLANG=$(TOOLCHAIN_ROOT)\usr\lib\clang false true true