Skip to content

Commit 89b27be

Browse files
committed
WiX: adjust the disk ids for the windows sdk
Ensure that these files are packaged into the appropriate cabs. When supporting the online installer, selecting (or de-selecting) an architecture should allow us to shave off the download for the components that are architecture specific. Make the default disk id (1) explicit as we prepare to add an experimental SDK.
1 parent 35dc26c commit 89b27be

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

platforms/Windows/platforms/windows/windows.wxs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -595,7 +595,7 @@
595595
<File Source="$(SDKRoot)\usr\lib\swift\windows\_Concurrency.swiftmodule\i686-unknown-windows-msvc.swiftmodule" />
596596
</Component>
597597

598-
<Component Directory="WindowsSDK_usr_lib_swift_windows_x86">
598+
<Component Directory="WindowsSDK_usr_lib_swift_windows_x86" DiskId="4">
599599
<File Source="$(SDKRoot)\usr\lib\swift\windows\i686\swift_Concurrency.lib" />
600600
</Component>
601601
</ComponentGroup>
@@ -1602,20 +1602,20 @@
16021602

16031603
<!-- apinotes -->
16041604
<ComponentGroup Id="apinotes" Directory="WindowsSDK_usr_lib_swift_apinotes">
1605-
<Component>
1605+
<Component DiskId="1">
16061606
<File Source="$(SDKRoot)\usr\lib\swift\apinotes\std.apinotes" />
16071607
</Component>
16081608
</ComponentGroup>
16091609

16101610
<!-- libcxxshim -->
16111611
<ComponentGroup Id="libcxxshim" Directory="WindowsSDK_usr_lib_swift_windows">
1612-
<Component>
1612+
<Component DiskId="1">
16131613
<File Source="$(SDKRoot)\usr\lib\swift\windows\libcxxshim.h" />
16141614
</Component>
1615-
<Component>
1615+
<Component DiskId="1">
16161616
<File Source="$(SDKRoot)\usr\lib\swift\windows\libcxxshim.modulemap" />
16171617
</Component>
1618-
<Component>
1618+
<Component DiskId="1">
16191619
<File Source="$(SDKRoot)\usr\lib\swift\windows\libcxxstdlibshim.h" />
16201620
</Component>
16211621
</ComponentGroup>
@@ -1660,46 +1660,46 @@
16601660

16611661
<!-- clang modules -->
16621662
<ComponentGroup Id="AuxiliaryFiles" Directory="WindowsSDK_usr_share">
1663-
<Component>
1663+
<Component DiskId="1">
16641664
<File Source="$(SDKRoot)\usr\share\ucrt.modulemap" />
16651665
</Component>
1666-
<Component>
1666+
<Component DiskId="1">
16671667
<File Source="$(SDKRoot)\usr\share\winsdk.modulemap" />
16681668
</Component>
1669-
<Component>
1669+
<Component DiskId="1">
16701670
<File Source="$(SDKRoot)\usr\share\vcruntime.apinotes" />
16711671
</Component>
1672-
<Component>
1672+
<Component DiskId="1">
16731673
<File Source="$(SDKRoot)\usr\share\vcruntime.modulemap" />
16741674
</Component>
16751675
</ComponentGroup>
16761676

16771677
<!-- Configuration -->
16781678
<ComponentGroup Id="Configuration">
1679-
<Component Directory="WindowsSDK">
1679+
<Component Directory="WindowsSDK" DiskId="1">
16801680
<File Source="$(SDKRoot)\SDKSettings.json" />
16811681
</Component>
1682-
<Component Directory="WindowsSDK">
1682+
<Component Directory="WindowsSDK" DiskId="1">
16831683
<File Source="$(SDKRoot)\SDKSettings.plist" />
16841684
</Component>
1685-
<Component Directory="WindowsPlatform">
1685+
<Component Directory="WindowsPlatform" DiskId="1">
16861686
<File Source="$(PlatformRoot)\Info.plist" />
16871687
</Component>
16881688
</ComponentGroup>
16891689

16901690
<!-- Redistributables -->
16911691
<?if $(IncludeARM64) = True?>
1692-
<Component Id="rtl.arm64.msm" Directory="RedistVersion" Condition="INSTALLARM64REDIST">
1692+
<Component Id="rtl.arm64.msm" Directory="RedistVersion" Condition="INSTALLARM64REDIST" DiskId="2">
16931693
<File Source="!(bindpath.rtl.arm64.msm)\rtl.arm64.msm" />
16941694
</Component>
16951695
<?endif?>
16961696
<?if $(IncludeX64) = True?>
1697-
<Component Id="rtl.amd64.msm" Directory="RedistVersion" Condition="INSTALLAMD64REDIST">
1697+
<Component Id="rtl.amd64.msm" Directory="RedistVersion" Condition="INSTALLAMD64REDIST" DiskId="3">
16981698
<File Source="!(bindpath.rtl.amd64.msm)\rtl.amd64.msm" />
16991699
</Component>
17001700
<?endif?>
17011701
<?if $(IncludeX86) = True?>
1702-
<Component Id="rtl.x86.msm" Directory="RedistVersion" Condition="INSTALLX86REDIST">
1702+
<Component Id="rtl.x86.msm" Directory="RedistVersion" Condition="INSTALLX86REDIST" DiskId="4">
17031703
<File Source="!(bindpath.rtl.x86.msm)\rtl.x86.msm" />
17041704
</Component>
17051705
<?endif?>

0 commit comments

Comments
 (0)