From 646ec555e43d3966ca97372d0a7d70aacf8e6867 Mon Sep 17 00:00:00 2001 From: Robert Widmann Date: Mon, 11 Nov 2019 15:20:04 -0800 Subject: [PATCH] [NFC] Drop typeCheckExternalDefinitions performTypeChecking will handle the nitty-gritty of closure captures, and external declarations are now eagerly typechecked. There's no reason to call this after the playground transform. --- .../Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp b/lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp index 4e8044258758a..eea2f44b34976 100644 --- a/lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp +++ b/lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp @@ -1498,7 +1498,6 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager, } } else { swift::performPlaygroundTransform(parsed_expr->source_file, true); - swift::typeCheckExternalDefinitions(parsed_expr->source_file); } // FIXME: We now should have to do the name binding and type