Skip to content

Commit d8b4e02

Browse files
authored
Merge pull request #7535 from rintaro/next-fetch-content
[next][lldb][CMake] Update for swift-syntax FetchContent changes
2 parents b340ec7 + 7c8484d commit d8b4e02

File tree

4 files changed

+17
-22
lines changed

4 files changed

+17
-22
lines changed

lldb/CMakeLists.txt

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,6 @@ if (LLDB_ENABLE_SWIFT_SUPPORT)
6262
endif()
6363
endif()
6464

65-
# When we have the early SwiftSyntax build, we can include its parser.
66-
if (LLDB_ENABLE_SWIFT_SUPPORT)
67-
if(SWIFT_PATH_TO_EARLYSWIFTSYNTAX_BUILD_DIR)
68-
set(SWIFT_PATH_TO_EARLYSWIFTSYNTAX_TARGETS
69-
${SWIFT_PATH_TO_EARLYSWIFTSYNTAX_BUILD_DIR}/cmake/SwiftSyntaxTargets.cmake)
70-
if(NOT EXISTS "${SWIFT_PATH_TO_EARLYSWIFTSYNTAX_TARGETS}")
71-
message(STATUS "Skipping Swift Swift parser integration due to missing early SwiftSyntax")
72-
else()
73-
set(SWIFT_SWIFT_PARSER TRUE)
74-
include(${SWIFT_PATH_TO_EARLYSWIFTSYNTAX_TARGETS})
75-
endif()
76-
endif()
77-
endif()
78-
# END - Swift Mods
79-
8065
# Define the LLDB_CONFIGURATION_xxx matching the build type.
8166
if(uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" )
8267
add_definitions(-DLLDB_CONFIGURATION_DEBUG)

lldb/cmake/modules/AddLLDB.cmake

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ function(add_properties_for_swift_modules target reldir)
191191
endif()
192192

193193
if (NOT BOOTSTRAPPING_MODE)
194-
if (SWIFT_SWIFT_PARSER)
194+
if (SWIFT_BUILD_SWIFT_SYNTAX)
195195
set(APSM_BOOTSTRAPPING_MODE "HOSTTOOLS")
196196
endif()
197197
else()
@@ -217,18 +217,28 @@ function(add_properties_for_swift_modules target reldir)
217217
# Workaround for a linker crash related to autolinking: rdar://77839981
218218
set_property(TARGET ${target} APPEND_STRING PROPERTY
219219
LINK_FLAGS " -lobjc ")
220+
221+
set_property(TARGET ${target} APPEND PROPERTY BUILD_RPATH "${SWIFT_BUILD_RPATH}")
222+
set_property(TARGET ${target} APPEND PROPERTY INSTALL_RPATH "${SWIFT_INSTALL_RPATH}")
220223
elseif (CMAKE_SYSTEM_NAME MATCHES "Linux|Android|OpenBSD|FreeBSD")
221224
string(REGEX MATCH "^[^-]*" arch ${LLVM_TARGET_TRIPLE})
222225
target_link_libraries(${target} PRIVATE swiftCore-linux-${arch})
223226
string(TOLOWER ${CMAKE_SYSTEM_NAME} platform)
224227
set(SWIFT_BUILD_RPATH "${LLDB_SWIFT_LIBS}/${platform}")
225228
set(SWIFT_INSTALL_RPATH "$ORIGIN/${reldir}lib/swift/${platform}")
229+
set_property(TARGET ${target} APPEND PROPERTY BUILD_RPATH "${SWIFT_BUILD_RPATH}")
230+
set_property(TARGET ${target} APPEND PROPERTY INSTALL_RPATH "${SWIFT_INSTALL_RPATH}")
231+
elseif(CMAKE_SYSTEM_NAME MATCHES Windows)
232+
if(CMAKE_SYSTEM_PROCESSOR MATCHES AMD64|amd64|x86_64)
233+
target_link_directories(${target} PRIVATE
234+
${SWIFT_PATH_TO_SWIFT_SDK}/usr/lib/swift/windows/x86_64)
235+
elseif(CMAKE_SYSTEM_PROCESSOR MATCHES ARM64|arm64|aarch64)
236+
target_link_directories(${target} PRIVATE
237+
${SWIFT_PATH_TO_SWIFT_SDK}/usr/lib/swift/windows/aarch64)
238+
endif()
226239
endif()
227240

228-
set_property(TARGET ${target} APPEND PROPERTY BUILD_RPATH "${SWIFT_BUILD_RPATH}")
229-
set_property(TARGET ${target} APPEND PROPERTY INSTALL_RPATH "${SWIFT_INSTALL_RPATH}")
230-
231-
if (SWIFT_SWIFT_PARSER)
241+
if (SWIFT_BUILD_SWIFT_SYNTAX)
232242
if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
233243
set_property(TARGET ${target}
234244
APPEND PROPERTY BUILD_RPATH "@loader_path/${build_reldir}lib/swift/host")

lldb/tools/lldb-server/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ target_include_directories(lldb-server PRIVATE "${LLDB_SOURCE_DIR}/source")
7070
target_link_libraries(lldb-server PRIVATE ${LLDB_SYSTEM_LIBS})
7171

7272
# BEGIN Swift Mods
73-
if(SWIFT_SWIFT_PARSER)
73+
if(SWIFT_BUILD_SWIFT_SYNTAX)
7474
add_properties_for_swift_modules(lldb-server "../")
7575
endif()
7676
# END Swift Mods

lldb/unittests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function(add_lldb_unittest test_name)
3636
target_link_libraries(${test_name} PRIVATE ${ARG_LINK_LIBS})
3737

3838
# BEGIN Swift Mods
39-
if(SWIFT_SWIFT_PARSER)
39+
if(SWIFT_BUILD_SWIFT_SYNTAX)
4040
add_properties_for_swift_modules(${test_name} "../")
4141
endif()
4242
# END Swift Mods

0 commit comments

Comments
 (0)