AMDGPU: Use less surprising form of ConstantFP::get (llvm#139248)

arsenm · web-flow · commit bb0a0782ea63 · 2025-05-09T14:55:44.000+02:00
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp b/llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp
@@ -906,8 +906,8 @@ GCNTTIImpl::instCombineIntrinsic(InstCombiner &IC, IntrinsicInst &II) const {
         if (const ConstantFP *C2 = dyn_cast<ConstantFP>(Src2)) {
           APFloat Result = fmed3AMDGCN(C0->getValueAPF(), C1->getValueAPF(),
                                        C2->getValueAPF());
-          return IC.replaceInstUsesWith(
-              II, ConstantFP::get(IC.Builder.getContext(), Result));
+          return IC.replaceInstUsesWith(II,
+                                        ConstantFP::get(II.getType(), Result));
         }
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -906,8 +906,8 @@ GCNTTIImpl::instCombineIntrinsic(InstCombiner &IC, IntrinsicInst &II) const {`
`906`	`906`	`if (const ConstantFP *C2 = dyn_cast<ConstantFP>(Src2)) {`
`907`	`907`	`APFloat Result = fmed3AMDGCN(C0->getValueAPF(), C1->getValueAPF(),`
`908`	`908`	`C2->getValueAPF());`
`909`		`- return IC.replaceInstUsesWith(`
`910`		`- II, ConstantFP::get(IC.Builder.getContext(), Result));`
	`909`	`+ return IC.replaceInstUsesWith(II,`
	`910`	`+ ConstantFP::get(II.getType(), Result));`
`911`	`911`	`}`
`912`	`912`	`}`
`913`	`913`	`}`