[lldb] Silence warning with latest MSVC on Windows

aganea · aganea · commit bafdaa171a28 · 2024-01-18T13:06:12.000-05:00
Fixes:
```
[3465/3822] Building CXX object tools\lldb\source\Plugins\SymbolFile\CTF\CMakeFiles\lldbPluginSymbolFileCTF.dir\SymbolFileCTF.cpp.obj
C:\git\llvm-project\lldb\source\Plugins\SymbolFile\CTF\SymbolFileCTF.cpp(606) : warning C4715: 'lldb_private::SymbolFileCTF::CreateType': not all control paths return a value
```
diff --git a/lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp b/lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp
@@ -603,6 +603,7 @@ llvm::Expected<TypeSP> SymbolFileCTF::CreateType(CTFType *ctf_type) {
                       ctf_type->uid, ctf_type->name, ctf_type->kind),
         llvm::inconvertibleErrorCode());
   }
+  llvm_unreachable("Unexpected CTF type kind");
 }
 
 llvm::Expected<std::unique_ptr<CTFType>>

Original file line number	Diff line number	Diff line change
`@@ -603,6 +603,7 @@ llvm::Expected<TypeSP> SymbolFileCTF::CreateType(CTFType *ctf_type) {`
`603`	`603`	`ctf_type->uid, ctf_type->name, ctf_type->kind),`
`604`	`604`	`llvm::inconvertibleErrorCode());`
`605`	`605`	`}`
	`606`	`+ llvm_unreachable("Unexpected CTF type kind");`
`606`	`607`	`}`
`607`	`608`
`608`	`609`	`llvm::Expected<std::unique_ptr<CTFType>>`