Skip to content

Commit 69ce2ae

Browse files
committed
[ConstantRange][LVI] Use overflow flags from sub to constrain the range
Summary: This notably improves non-negativity deduction: ``` | statistic | old | new | delta | % change | | correlated-value-propagation.NumAShrs | 209 | 227 | 18 | 8.6124% | | correlated-value-propagation.NumAddNSW | 4972 | 4988 | 16 | 0.3218% | | correlated-value-propagation.NumAddNUW | 7141 | 7148 | 7 | 0.0980% | | correlated-value-propagation.NumAddNW | 12113 | 12136 | 23 | 0.1899% | | correlated-value-propagation.NumAnd | 442 | 445 | 3 | 0.6787% | | correlated-value-propagation.NumNSW | 7160 | 7176 | 16 | 0.2235% | | correlated-value-propagation.NumNUW | 13306 | 13316 | 10 | 0.0752% | | correlated-value-propagation.NumNW | 20466 | 20492 | 26 | 0.1270% | | correlated-value-propagation.NumSDivs | 207 | 212 | 5 | 2.4155% | | correlated-value-propagation.NumSExt | 6279 | 6679 | 400 | 6.3704% | | correlated-value-propagation.NumSRems | 28 | 29 | 1 | 3.5714% | | correlated-value-propagation.NumShlNUW | 2793 | 2796 | 3 | 0.1074% | | correlated-value-propagation.NumShlNW | 3964 | 3967 | 3 | 0.0757% | | correlated-value-propagation.NumUDivs | 353 | 358 | 5 | 1.4164% | | instcount.NumAShrInst | 13763 | 13741 | -22 | -0.1598% | | instcount.NumAddInst | 277349 | 277348 | -1 | -0.0004% | | instcount.NumLShrInst | 27437 | 27463 | 26 | 0.0948% | | instcount.NumOrInst | 102677 | 102678 | 1 | 0.0010% | | instcount.NumSDivInst | 8732 | 8727 | -5 | -0.0573% | | instcount.NumSExtInst | 80872 | 80468 | -404 | -0.4996% | | instcount.NumSRemInst | 1679 | 1678 | -1 | -0.0596% | | instcount.NumTruncInst | 62154 | 62153 | -1 | -0.0016% | | instcount.NumUDivInst | 2526 | 2527 | 1 | 0.0396% | | instcount.NumURemInst | 1589 | 1590 | 1 | 0.0629% | | instcount.NumZExtInst | 69405 | 69809 | 404 | 0.5821% | | instcount.TotalInsts | 7439575 | 7439574 | -1 | 0.0000% | ``` Reviewers: nikic, reames, spatel Reviewed By: nikic Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D69942
1 parent 6fc73f6 commit 69ce2ae

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

llvm/lib/IR/ConstantRange.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -824,6 +824,8 @@ ConstantRange ConstantRange::overflowingBinaryOp(Instruction::BinaryOps BinOp,
824824
switch (BinOp) {
825825
case Instruction::Add:
826826
return addWithNoWrap(Other, NoWrapKind);
827+
case Instruction::Sub:
828+
return subWithNoWrap(Other, NoWrapKind);
827829
default:
828830
// Don't know about this Overflowing Binary Operation.
829831
// Conservatively fallback to plain binop handling.

llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -490,11 +490,9 @@ define i1 @test16(i32 %a, i32 %b) {
490490
; CHECK-NEXT: [[SUB:%.*]] = sub nuw nsw i32 [[A]], [[B]]
491491
; CHECK-NEXT: br label [[CONT:%.*]]
492492
; CHECK: cont:
493-
; CHECK-NEXT: [[RES:%.*]] = icmp sge i32 [[SUB]], 0
494493
; CHECK-NEXT: br label [[EXIT]]
495494
; CHECK: exit:
496-
; CHECK-NEXT: [[IV:%.*]] = phi i1 [ true, [[BEGIN:%.*]] ], [ [[RES]], [[CONT]] ]
497-
; CHECK-NEXT: ret i1 [[IV]]
495+
; CHECK-NEXT: ret i1 true
498496
;
499497
begin:
500498
%cmp0 = icmp sge i32 %a, 0
@@ -598,11 +596,9 @@ define i1 @test19(i32 %a, i32 %b) {
598596
; CHECK-NEXT: [[SUB:%.*]] = sub nsw i32 [[A]], [[B]]
599597
; CHECK-NEXT: br label [[CONT:%.*]]
600598
; CHECK: cont:
601-
; CHECK-NEXT: [[RES:%.*]] = icmp sle i32 [[SUB]], 0
602599
; CHECK-NEXT: br label [[EXIT]]
603600
; CHECK: exit:
604-
; CHECK-NEXT: [[IV:%.*]] = phi i1 [ true, [[BEGIN:%.*]] ], [ [[RES]], [[CONT]] ]
605-
; CHECK-NEXT: ret i1 [[IV]]
601+
; CHECK-NEXT: ret i1 true
606602
;
607603
begin:
608604
%cmp0 = icmp sle i32 %a, 0

0 commit comments

Comments
 (0)