[lldb-vscode][NFC] Access a pointee type in a simpler way

The new code is a bit simpler bit achieves the same goal. A small test was added just in case.

Author: walter erquinigo

lldb/test/API/tools/lldb-vscode/evaluate/TestVSCode_evaluate.py

@@ -62,6 +62,9 @@ def run_test_evaluate_expressions(
         self.assertEvaluate(
             "struct1", "{foo:15}" if enableAutoVariableSummaries else "my_struct @ 0x"
         )
+        self.assertEvaluate(
+            "struct2", "{foo:16}" if enableAutoVariableSummaries else "0x.*"
+        )
         self.assertEvaluate("struct1.foo", "15")
         self.assertEvaluate("struct2->foo", "16")
 

lldb/tools/lldb-vscode/JSONUtils.cpp

@@ -203,10 +203,9 @@ static bool ShouldBeDereferencedForSummary(lldb::SBValue &v) {
   if (!v.GetType().IsPointerType() && !v.GetType().IsReferenceType())
     return false;
 
-  // If it's a pointer to a pointer, we don't dereference to avoid confusing
+  // If we are referencing a pointer, we don't dereference to avoid confusing
   // the user with the addresses that could shown in the summary.
-  if (v.GetType().IsPointerType() &&
-      v.GetType().GetDereferencedType().IsPointerType())
+  if (v.Dereference().GetType().IsPointerType())
     return false;
 
   // If it's synthetic or a pointer to a basic type that provides a summary, we