use make_scope_exit

Author: kastiglione

lldb/source/Target/Target.cpp

@@ -2286,6 +2286,9 @@ Target::GetScratchTypeSystemForLanguage(lldb::LanguageType language,
         // thread) is holding a read lock to the scratch context and
         // replacing it could cause a use-after-free later on.
         if (GetSwiftScratchContextLock().try_lock()) {
+          auto unlock = llvm::make_scope_exit([this] {
+            GetSwiftScratchContextLock().unlock();
+          });
           if (m_use_scratch_typesystem_per_module)
             DisplayFallbackSwiftContextErrors(swift_ast_ctx);
           else if (StreamSP errs = GetDebugger().GetAsyncErrorStream()) {
@@ -2309,10 +2312,8 @@ Target::GetScratchTypeSystemForLanguage(lldb::LanguageType language,
           m_scratch_type_system_map.RemoveTypeSystemsForLanguage(language);
           type_system_or_err = m_scratch_type_system_map.GetTypeSystemForLanguage(
               language, this, create_on_demand, compiler_options);
-          if (!type_system_or_err) {
-            GetSwiftScratchContextLock().unlock();
+          if (!type_system_or_err)
             return type_system_or_err.takeError();
-          }
 
           if (auto *new_swift_ast_ctx =
                   llvm::dyn_cast_or_null<SwiftASTContextForExpressions>(
@@ -2337,7 +2338,6 @@ Target::GetScratchTypeSystemForLanguage(lldb::LanguageType language,
                   llvm::make_error<llvm::StringError>("DIAF", llvm::inconvertibleErrorCode());
             }
           }
-          GetSwiftScratchContextLock().unlock();
         }
       }
     } else if (create_on_demand) {