soundness

Author: dnadoba

Sources/AsyncHTTPClient/ConnectionPool.swift

@@ -28,7 +28,7 @@ extension String {
         var ipv6Address = in6_addr()
         return self.withCString { host in
             inet_pton(AF_INET, host, &ipv4Address) == 1 ||
-            inet_pton(AF_INET6, host, &ipv6Address) == 1
+                inet_pton(AF_INET6, host, &ipv6Address) == 1
         }
     }
 }

Sources/AsyncHTTPClient/ConnectionPool/RequestOptions.swift

@@ -17,7 +17,7 @@ import NIOCore
 struct RequestOptions {
     /// The maximal `TimeAmount` that is allowed to pass between `channelRead`s from the Channel.
     var idleReadTimeout: TimeAmount?
-    
+
     var dnsOverride: [String: String]
 
     init(idleReadTimeout: TimeAmount?, dnsOverride: [String: String]) {

Sources/AsyncHTTPClient/HTTPClient.swift

@@ -711,7 +711,7 @@ public class HTTPClient {
     public struct Configuration {
         /// TLS configuration, defaults to `TLSConfiguration.makeClientConfiguration()`.
         public var tlsConfiguration: Optional<TLSConfiguration>
-        
+
         /// Sometimes it can be useful to connect to one host e.g. `x.example.com` but
         /// request and validate the certificate chain as if we would connect to `y.example.com`.
         /// ``dnsOverride`` allows to do just that by mapping host names which we will request and validate the certificate chain, to a different
@@ -721,7 +721,7 @@ public class HTTPClient {
         /// `url` of `https://example.com/`, the ``HTTPClient`` will actually open a connection to `localhost` instead of `example.com`.
         /// ``HTTPClient`` will still request certificates from the server for `example.com` and validate them as if we would connect to `example.com`.
         public var dnsOverride: [String: String] = [:]
-        
+
         /// Enables following 3xx redirects automatically.
         ///
         /// Following redirects are supported:

Sources/AsyncHTTPClient/NIOTransportServices/TLSConfiguration.swift

@@ -91,7 +91,7 @@ extension TLSConfiguration {
         will make AsyncHTTPClient use NIO on BSD Sockets and not Network.framework (which is the preferred \
         platform networking stack).
         """
-        
+
         if let serverNameIndicatorOverride = serverNameIndicatorOverride {
             serverNameIndicatorOverride.withCString { serverNameIndicatorOverride in
                 sec_protocol_options_set_tls_server_name(options.securityProtocolOptions, serverNameIndicatorOverride)

Sources/AsyncHTTPClient/RequestBag.swift

@@ -26,9 +26,9 @@ final class RequestBag<Delegate: HTTPClientResponseDelegate> {
     private static var maxConsumeBodyPartStackDepth: Int {
         50
     }
-    
+
     let poolKey: ConnectionPool.Key
-    
+
     let task: HTTPClient.Task<Delegate.Response>
     var eventLoop: EventLoop {
         self.task.eventLoop
@@ -395,7 +395,6 @@ final class RequestBag<Delegate: HTTPClientResponseDelegate> {
 }
 
 extension RequestBag: HTTPSchedulableRequest {
-
     var tlsConfiguration: TLSConfiguration? {
         self.request.tlsConfiguration
     }

Tests/AsyncHTTPClientTests/AsyncAwaitEndToEndTests+XCTest.swift

@@ -40,6 +40,7 @@ extension AsyncAwaitEndToEndTests {
             ("testImmediateDeadline", testImmediateDeadline),
             ("testConnectTimeout", testConnectTimeout),
             ("testSelfSignedCertificateIsRejectedWithCorrectErrorIfRequestDeadlineIsExceeded", testSelfSignedCertificateIsRejectedWithCorrectErrorIfRequestDeadlineIsExceeded),
+            ("testDnsOverride", testDnsOverride),
             ("testInvalidURL", testInvalidURL),
             ("testRedirectChangesHostHeader", testRedirectChangesHostHeader),
             ("testShutdown", testShutdown),

Tests/AsyncHTTPClientTests/AsyncAwaitEndToEndTests.swift

@@ -491,7 +491,7 @@ final class AsyncAwaitEndToEndTests: XCTestCase {
             }
         }
     }
-    
+
     func testDnsOverride() {
         guard #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *) else { return }
         XCTAsyncTest(timeout: 5) {
@@ -517,7 +517,7 @@ final class AsyncAwaitEndToEndTests: XCTestCase {
             ///     },
             ///     issuerPrivateKey: .init(privateKey)
             /// )
-            ///```
+            /// ```
             let certPath = Bundle.module.path(forResource: "example.com.cert", ofType: "pem")!
             let keyPath = Bundle.module.path(forResource: "example.com.private-key", ofType: "pem")!
             let localhostCert = try NIOSSLCertificate.fromPEMFile(certPath)
@@ -531,12 +531,12 @@ final class AsyncAwaitEndToEndTests: XCTestCase {
             var config = HTTPClient.Configuration()
                 .enableFastFailureModeForTesting()
             var tlsConfig = TLSConfiguration.makeClientConfiguration()
-            
+
             tlsConfig.trustRoots = .certificates(localhostCert)
             config.tlsConfiguration = tlsConfig
             // this is the actual configuration under test
             config.dnsOverride = ["example.com": "localhost"]
-            
+
             let localClient = HTTPClient(eventLoopGroupProvider: .createNew, configuration: config)
             defer { XCTAssertNoThrow(try localClient.syncShutdown()) }
             let request = HTTPClientRequest(url: "https://example.com:\(bin.port)/echo-headers")

Tests/AsyncHTTPClientTests/HTTPClientTestUtils.swift

@@ -341,7 +341,7 @@ internal final class HTTPBin<RequestHandler: ChannelInboundHandler> where
             compress: Bool = false,
             settings: HTTP2Settings? = nil
         )
-        
+
         static func http1_1(ssl: Bool, compress: Bool = false) -> Self {
             .http1_1(tlsConfiguration: ssl ? nil : TestTLS.serverConfiguration, compress: compress)
         }
@@ -367,7 +367,7 @@ internal final class HTTPBin<RequestHandler: ChannelInboundHandler> where
                 return customSettings
             }
         }
-        
+
         var tlsConfiguration: TLSConfiguration? {
             switch self {
             case .refuse: