Allow errors thrown by SecCertificateCreateWithData to passed up the callstack

Author: adam-fowler

Sources/AsyncHTTPClient/NIOTransportServices/TLSConfiguration.swift

@@ -60,7 +60,7 @@
         ///
         /// - Parameter queue: Dispatch queue to run `sec_protocol_options_set_verify_block` on.
         /// - Returns: Equivalent NWProtocolTLS Options
-        func getNWProtocolTLSOptions() -> NWProtocolTLS.Options {
+        func getNWProtocolTLSOptions() throws -> NWProtocolTLS.Options {
             let options = NWProtocolTLS.Options()
 
             // minimum TLS protocol
@@ -113,12 +113,8 @@
             var secTrustRoots: [SecCertificate]?
             switch trustRoots {
             case .some(.certificates(let certificates)):
-                do {
-                    secTrustRoots = try certificates.compactMap { certificate in
-                        try SecCertificateCreateWithData(nil, Data(certificate.toDERBytes()) as CFData)
-                    }
-                } catch {
-                    // failed to load
+                secTrustRoots = try certificates.compactMap { certificate in
+                    try SecCertificateCreateWithData(nil, Data(certificate.toDERBytes()) as CFData)
                 }
             case .some(.file):
                 preconditionFailure("TLSConfiguration.trustRoots.file is not supported")

Sources/AsyncHTTPClient/Utils.swift

@@ -89,7 +89,7 @@ extension NIOClientTCPBootstrap {
                 } else {
                     // create NIOClientTCPBootstrap with NIOTS TLS provider
                     let tlsConfiguration = configuration.tlsConfiguration ?? TLSConfiguration.forClient()
-                    let parameters = tlsConfiguration.getNWProtocolTLSOptions()
+                    let parameters = try tlsConfiguration.getNWProtocolTLSOptions()
                     let tlsProvider = NIOTSClientTLSProvider(tlsOptions: parameters)
                     bootstrap = NIOClientTCPBootstrap(tsBootstrap, tls: tlsProvider)
                 }