Skip to content

[Core] DefaultGenerator is reading system properties #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
edrevo opened this issue Jul 18, 2017 · 2 comments
Closed

[Core] DefaultGenerator is reading system properties #6101

edrevo opened this issue Jul 18, 2017 · 2 comments

Comments

@edrevo
Copy link
Contributor

edrevo commented Jul 18, 2017

Description

DefaultGenerator has several calls to System.getProperty that change the behavior of the class. This makes sense in the context of the CLI, but since this class isn't part of the cli project, it seems more reasonable that these parameters be passed in ClientOpts or some other Opt class.

This would make DefaultGenerator easier to use as a library

Swagger-codegen version

2.2.3
@wing328
Copy link
Contributor

wing328 commented Jul 19, 2017

@edrevo Here is a related discussion: #6041

@edrevo
Copy link
Contributor Author

edrevo commented Jul 19, 2017

Great, thanks for the pointer. I'll close this issue since it seems like a dupe of the one you mentioned.

@edrevo edrevo closed this as completed Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wing328 @edrevo