Skip to content

support file download #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fehguy opened this issue Oct 28, 2014 · 14 comments
Closed

support file download #319

fehguy opened this issue Oct 28, 2014 · 14 comments
Assignees
Milestone

Comments

@fehguy
Copy link
Contributor

fehguy commented Oct 28, 2014

based on https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#responseSchema

@fehguy fehguy added this to the v2.1.0-M2 milestone Dec 24, 2014
@webron webron modified the milestones: v2.1.0, v2.1.0-M2 May 3, 2015
@lakeba
Copy link

lakeba commented Jun 21, 2015

any news on this feature?

@wing328
Copy link
Contributor

wing328 commented Jun 21, 2015

It's a limitation with the spec at the moment. Please refer to OAI/OpenAPI-Specification#50 for the latest discussion.

@webron
Copy link
Contributor

webron commented Jun 21, 2015

@wing328 - not quite. There is a solution in the spec for file downloads using the file type in responses. That applies to this issue regardless of the #50 issue in the swagger-spec.

@wing328
Copy link
Contributor

wing328 commented Jun 21, 2015

Ah ok. Sorry I got confused before.

Ron [email protected] 於 2015年6月21日 下午5:42 寫道:

@wing328 - not quite. There is a solution in the spec for file downloads using the file type in responses. That applies to this issue regardless of the #50 issue in the swagger-spec.


Reply to this email directly or view it on GitHub.

@lakeba
Copy link

lakeba commented Jun 21, 2015

I don't think that .NET have a file type as response.

@webron
Copy link
Contributor

webron commented Jun 22, 2015

@lakeba - it's not about .NET, it's about how Swashbuckle translates the code to the Swagger definition. I don't know what's common there and how it is translated (there's normally more than one method).

@wing328
Copy link
Contributor

wing328 commented Jun 29, 2015

For C#, I've submitted a PR #927 to support the feature.

@lakeba do you mind help doing a test to see if it would meet your requirement ?

@lakeba
Copy link

lakeba commented Jun 29, 2015

I will do

@wing328 wing328 modified the milestones: Future, v2.1.0 Mar 17, 2016
@fantapop
Copy link

This is an old one. @wing328 Any updates here?

@wing328
Copy link
Contributor

wing328 commented Feb 25, 2020

@fantapop thanks for tagging me but I'm no longer involved in this project. I hope others will help you out. Good luck.

@HugoMario HugoMario self-assigned this Feb 27, 2020
@Alec321
Copy link

Alec321 commented May 7, 2020

@HugoMario any updates?

@HugoMario
Copy link
Contributor

@Alec321
unfortunately no, been busy in other issues :(

@ak89224
Copy link

ak89224 commented Jun 12, 2020

@HugoMario Any workaround either for the issue ?

@HugoMario
Copy link
Contributor

This has been implemented in multiple generators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants