Skip to content

Pin mapbox to 0.52 #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rich-Harris opened this issue Mar 22, 2019 · 6 comments
Closed

Pin mapbox to 0.52 #2297

Rich-Harris opened this issue Mar 22, 2019 · 6 comments

Comments

@Rich-Harris
Copy link
Member

A new Mapbox GL version breaks the context API tutorial — will need to pin to 0.52, or figure out how to serve 0.53 from bundle.run

@Conduitry
Copy link
Member

Bonus if we do manage to get it to work with 0.53.1: You can now have mapbox tokens that can only be used at specific domains or URLs.

@mourner
Copy link

mourner commented Mar 22, 2019

https://bundle.run/[email protected] works. BTW, any reason to use bundle.run instead of the official build at https://api.tiles.mapbox.com/mapbox-gl-js/v0.53.1/mapbox-gl.js?

@Rich-Harris
Copy link
Member Author

I'm seeing this error, are you getting something else?

Screen Shot 2019-03-22 at 15 13 28

bundle.run is just what the REPL uses when you do import whatever from 'whatever'. We could certainly do import mapbox from 'https://api.tiles.mapbox.com/mapbox-gl-js/v0.53.1/mapbox-gl.js' but I think it's better if we can show the code that a user would write in their own app, which would generally import from node_modules.

@Conduitry
Copy link
Member

Conduitry commented Mar 22, 2019

I'm getting that same error on 0.53.1 on bundle.run. On the demo instance https://packd.now.sh/[email protected] however - after a lot of churning - I did get a bundle back. I don't know what that means.

@mourner
Copy link

mourner commented Mar 22, 2019

@Rich-Harris yep, getting something else!

image

So maybe this is an error that happened for some CDN regions of bundle.run but not others, not sure... Certainly doesn't seem to be an issue with GL JS specifically, just some erratic bundler crash.

@Rich-Harris
Copy link
Member Author

My favourite kind of bug 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants