Skip to content

Commit b212b17

Browse files
authored
fix: skip deriveds for props with known safe calls (#11595)
1 parent faa2e93 commit b212b17

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

.changeset/popular-apes-bathe.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: skip deriveds for props with known safe calls

packages/svelte/src/compiler/phases/2-analyze/index.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1042,6 +1042,9 @@ function is_known_safe_call(node, context) {
10421042
return true;
10431043
}
10441044
}
1045+
1046+
// TODO add more cases
1047+
10451048
return false;
10461049
}
10471050

@@ -1262,11 +1265,12 @@ const common_visitors = {
12621265
}
12631266
},
12641267
CallExpression(node, context) {
1268+
const { expression } = context.state;
12651269
if (
1266-
context.state.expression?.type === 'ExpressionTag' ||
1267-
(context.state.expression?.type === 'SpreadAttribute' && !is_known_safe_call(node, context))
1270+
(expression?.type === 'ExpressionTag' || expression?.type === 'SpreadAttribute') &&
1271+
!is_known_safe_call(node, context)
12681272
) {
1269-
context.state.expression.metadata.contains_call_expression = true;
1273+
expression.metadata.contains_call_expression = true;
12701274
}
12711275

12721276
const callee = node.callee;

0 commit comments

Comments
 (0)