Skip to content

Commit 669d2d7

Browse files
authored
fix: preserve getters/setters in HMR mode (#11231)
fixes #11228
1 parent 516cd22 commit 669d2d7

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.changeset/tender-rocks-walk.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"svelte": patch
3+
---
4+
5+
fix: preserve getters/setters in HMR mode

packages/svelte/src/internal/client/dev/hmr.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,11 @@ export function hmr(source) {
2828

2929
effect = branch(() => {
3030
set_should_intro(false);
31-
Object.assign(instance, component(anchor, props));
31+
// preserve getters/setters
32+
Object.defineProperties(
33+
instance,
34+
Object.getOwnPropertyDescriptors(component(anchor, props))
35+
);
3236
set_should_intro(true);
3337
});
3438
});

0 commit comments

Comments
 (0)